Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to retrieve source volumes #97

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

AnikaAgiwal2711
Copy link
Collaborator

@AnikaAgiwal2711 AnikaAgiwal2711 commented Jan 30, 2024

Description

Function to get the volume assigned to snapshot policy.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit test and integration test added
Integration test result:
image

code coverage :
image

Unit test result:
image

Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the checks that are failing

@AkshaySainiDell AkshaySainiDell changed the title added one more function to retrieve source volumes Added function to retrieve source volumes Feb 6, 2024
@AnikaAgiwal2711 AnikaAgiwal2711 merged commit c8190fc into main Feb 6, 2024
1 of 4 checks passed
@shanmydell shanmydell deleted the snap-policy branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants