Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UT Coverage #66

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Improve UT Coverage #66

merged 3 commits into from
Jan 10, 2025

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Dec 18, 2024 •
edited
Loading

Description

Improve UT Coverage

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • unit-test
    image

adarsh-dell
adarsh-dell reviewed Jan 9, 2025
View reviewed changes
ipinterface_test.go Outdated Show resolved Hide resolved
@suryagupta4 suryagupta4 force-pushed the usr/suryagupta4/ut-coverage branch from a87c824 to 9086cbf Compare January 9, 2025 13:24
@suryagupta4 suryagupta4 marked this pull request as ready for review January 9, 2025 13:30
karthikk92
karthikk92 previously approved these changes Jan 9, 2025
View reviewed changes
@adarsh-dell
Copy link
Contributor

@suryagupta4 Please add a github issue, follow the checklist and resolve the conflicts.
Thanks

@suryagupta4
Copy link
Contributor Author

@suryagupta4 Please add a github issue, follow the checklist and resolve the conflicts. Thanks

Done

@karthikk92 karthikk92 merged commit 86ba8b9 into main Jan 10, 2025
6 checks passed
@karthikk92 karthikk92 deleted the usr/suryagupta4/ut-coverage branch January 10, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell left review comments

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryagupta4 @adarsh-dell @karthikk92 @AkshaySainiDell