Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts/csi-unity] Centralize all images to one place #312

Merged
merged 14 commits into from
Nov 7, 2023
Merged

[charts/csi-unity] Centralize all images to one place #312

merged 14 commits into from
Nov 7, 2023

Conversation

atye
Copy link
Contributor

@atye atye commented Oct 20, 2023 •
edited by shaynafinocchiaro
Loading

Is this a new chart?

No

What this PR does / why we need it:

Simplify images customization by centralizing them in one place

Which issue(s) is this PR associated with:

Special notes for your reviewer:

/!\ Only the syntax has been tested (passed with helm install unity ./csi-unity -n unity --debug --dry-run ) per agreement on Slack the Scrum team will validate the e2e installation.

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

@atye atye changed the title Unity Driver Images Test PR [charts/csi-unity] Centralize all images to one place Oct 20, 2023
@coulof coulof mentioned this pull request Oct 20, 2023
Closed
3 tasks
cbartoszDell
cbartoszDell previously approved these changes Oct 20, 2023
View reviewed changes
@atye
Copy link
Contributor Author

atye commented Oct 20, 2023 •
edited
Loading

@coulof Ensure that the images are up-to-date for 1.9.

@coulof
Copy link
Collaborator

coulof commented Oct 26, 2023

@coulof Ensure that the images are up-to-date for 1.9.

@atye, the sidecars are bumped to the latest version. I let the unity team decide on when to bump to v2.9.0

@coulof coulof mentioned this pull request Oct 26, 2023
Merged
3 tasks
shanduur-dell
shanduur-dell previously approved these changes Oct 26, 2023
View reviewed changes
gallacher
gallacher previously approved these changes Oct 31, 2023
View reviewed changes
KshitijaKakde and others added 11 commits November 7, 2023 10:48
@KshitijaKakde @atye
PowerFlex v2.8.0 release (#250)
f558446
@coulof @atye
Centralized images
be3b4d8
@alankar-verma @suryagupta4 @atye
Adding CSI Powerstore driver’s effective pod security profile for sup…
8751259 
…porting ephemeral volumes as part of Openshift 4.13 support (#261)

Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
@VamsiSiddu-7 @atye
removed externalAccess from powerflex manifests. (#283)
a4868cb
@alankar-verma @atye
Revert "Adding CSI Powerstore driver’s effective pod security profile…
1f25dbc 
… for supporting ephemeral volumes as part of Openshift 4.13 support (#261)" (#284)

This reverts commit c1dd93b.
@coulof @atye
Bump sidecars versions
195e1e2
@panigs7 @atye
Bump up observability version for CSM 1.9 (#314)
dfa6a4a 
* Bump-up observability version for CSM 1.9

* add patch verb to powerscale

* Add codeowners
@VamsiSiddu-7 @atye
update attacher sidecar for powerflex and powerstore. (#315)
d63513b
@coulof @atye
[charts/csi-powerstore] Centralize all images to one place (#310)
3394a3f 
* One place to configure all images
* Use latest versions of CSI official sidecars
* Set Default container to the driver and avoid podmon logs by default
* Fix annotation and remove driverVersion
@coulof @atye
[charts/csi-powerflex] Centralize all images to one place #263 (#311)
b656c2b 
* Centralize all images to one place

* Use latest CSI sidecars and default container to driver

* Add default annotation

* Use bleeding edge helm validation action to workaround cosign issue
@coulof @atye
[charts/csi-powermax] Container images in one place (#309)
8597b9d 
* One place to configure all images
* Fix the csi provisioner to use the full name
* Use latest versions of CSI official sidecars
@atye atye dismissed stale reviews from shanduur-dell and gallacher via 8597b9d November 7, 2023 15:49
@atye atye force-pushed the unity-driver-images-test branch from c1a5967 to 8597b9d Compare November 7, 2023 15:49
coulof
coulof requested changes Nov 7, 2023
View reviewed changes
charts/csi-unity/values.yaml Show resolved Hide resolved
@atye
Copy link
Contributor Author

atye commented Nov 7, 2023

@coulof Change is fixed for duplicate podmon image.

@atye atye requested a review from coulof November 7, 2023 16:20
@shaynafinocchiaro
Copy link
Contributor

There are duplicate entries for module images in isilon values too
https://github.com/dell/helm-charts/blob/release-v1.9.0/charts/csi-isilon/values.yaml#L144
https://github.com/dell/helm-charts/blob/release-v1.9.0/charts/csi-isilon/values.yaml#L378

coulof
coulof approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@coulof coulof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atye
Copy link
Contributor Author

atye commented Nov 7, 2023

There are duplicate entries for module images in isilon values too https://github.com/dell/helm-charts/blob/release-v1.9.0/charts/csi-isilon/values.yaml#L144 https://github.com/dell/helm-charts/blob/release-v1.9.0/charts/csi-isilon/values.yaml#L378

Addressed in #320.

@atye atye merged commit 8621a19 into release-v1.9.0 Nov 7, 2023
4 checks passed
@atye atye deleted the unity-driver-images-test branch November 7, 2023 17:53
tdawe pushed a commit that referenced this pull request Dec 13, 2023
@atye @KshitijaKakde
@coulof @alankar-verma @suryagupta4 @VamsiSiddu-7 @panigs7 @tdawe
[charts/csi-unity] Centralize all images to one place (#312)
8eb4974 
* PowerFlex v2.8.0 release (#250)

* Centralized images

* Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261)

Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>

* removed externalAccess from powerflex manifests. (#283)

* Revert "Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261)" (#284)

This reverts commit c1dd93b.

* Bump sidecars versions

* Bump up observability version for CSM 1.9 (#314)

* Bump-up observability version for CSM 1.9

* add patch verb to powerscale

* Add codeowners

* update attacher sidecar for powerflex and powerstore. (#315)

* [charts/csi-powerstore] Centralize all images to one place (#310)

* One place to configure all images
* Use latest versions of CSI official sidecars
* Set Default container to the driver and avoid podmon logs by default
* Fix annotation and remove driverVersion

* [charts/csi-powerflex] Centralize all images to one place #263 (#311)

* Centralize all images to one place

* Use latest CSI sidecars and default container to driver

* Add default annotation

* Use bleeding edge helm validation action to workaround cosign issue

* [charts/csi-powermax] Container images in one place (#309)

* One place to configure all images
* Fix the csi provisioner to use the full name
* Use latest versions of CSI official sidecars

* remove duplicate podmon image

---------

Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: coulof <florian.coulombel@dell.com>
Co-authored-by: alankar-verma <125348121+alankar-verma@users.noreply.github.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: VamsiSiddu-7 <103578883+VamsiSiddu-7@users.noreply.github.com>
Co-authored-by: coulof <49235405+coulof@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
tdawe added a commit to tdawe/helm-charts-dec13 that referenced this pull request Dec 13, 2023
@tdawe @suryagupta4
@VamsiSiddu-7 @panigs7 @coulof @boyamurthy @atye @KshitijaKakde @khareRajshree @aqu-dell @alikdell @alankar-verma @shaynafinocchiaro @xuluna @adarsh-dell @PeresKereotubo @AkshaySainiDell @HarishH-DELL
Release v1.9.0 (#1)
29b3515 
* [charts/csi-powerstore] Add PowerStore v2.9.0 support & sidecar version update (dell#303)

* powerstore v2.9.0 support

* sidecar version update

* csi-powerflex v2.9.0 changes. (dell#308)

* Bump up observability version for CSM 1.9 (dell#314)

* Bump-up observability version for CSM 1.9

* add patch verb to powerscale

* Add codeowners

* update attacher sidecar for powerflex and powerstore. (dell#315)

* [charts/csi-powerstore] Centralize all images to one place (dell#310)

* One place to configure all images
* Use latest versions of CSI official sidecars
* Set Default container to the driver and avoid podmon logs by default
* Fix annotation and remove driverVersion

* [charts/csi-powerflex] Centralize all images to one place dell#263 (dell#311)

* Centralize all images to one place

* Use latest CSI sidecars and default container to driver

* Add default annotation

* Use bleeding edge helm validation action to workaround cosign issue

* [charts/csi-powermax] Container images in one place (dell#309)

* One place to configure all images
* Fix the csi provisioner to use the full name
* Use latest versions of CSI official sidecars

* Removing linked proxy mode for proxy (dell#301)

* Updatting latest sidecars for Powermax (dell#319)

* [charts/powerscale] Powerscale driver images in one place (dell#313)

* PowerFlex v2.8.0 release (dell#250)

* PowerFlex  SDC  updated (dell#251)

* Centralized images

* minor typo fixed (dell#258)

* powerstore v2.8.0 & k8s 1.28 support (dell#262)

* update auth to 1.8 (dell#271)

* update auth to 1.8

Signed-off-by: arnchiequ-dell <arnchie.qu@dell.com>

* Updating podmon to 1.7

Signed-off-by: arnchiequ-dell <arnchie.qu@dell.com>

* Update Observability values file for Authorization sidecar image version

---------

Signed-off-by: arnchiequ-dell <arnchie.qu@dell.com>
Co-authored-by: Alik Saring <alik.saring@dell.com>

* Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (dell#261)

Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>

* removed externalAccess from powerflex manifests. (dell#283)

* Revert "Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (dell#261)" (dell#284)

This reverts commit c1dd93b.

* NFS ACL parameter removed (dell#289)

* fix values

---------

Signed-off-by: arnchiequ-dell <arnchie.qu@dell.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: coulof <florian.coulombel@dell.com>
Co-authored-by: Rajshree Khare <69839943+khareRajshree@users.noreply.github.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: aqu-dell <108017114+arnchiequ-dell@users.noreply.github.com>
Co-authored-by: Alik Saring <alik.saring@dell.com>
Co-authored-by: alankar-verma <125348121+alankar-verma@users.noreply.github.com>
Co-authored-by: VamsiSiddu-7 <103578883+VamsiSiddu-7@users.noreply.github.com>

* [charts/csi-unity] Centralize all images to one place (dell#312)

* PowerFlex v2.8.0 release (dell#250)

* Centralized images

* Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (dell#261)

Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>

* removed externalAccess from powerflex manifests. (dell#283)

* Revert "Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (dell#261)" (dell#284)

This reverts commit c1dd93b.

* Bump sidecars versions

* Bump up observability version for CSM 1.9 (dell#314)

* Bump-up observability version for CSM 1.9

* add patch verb to powerscale

* Add codeowners

* update attacher sidecar for powerflex and powerstore. (dell#315)

* [charts/csi-powerstore] Centralize all images to one place (dell#310)

* One place to configure all images
* Use latest versions of CSI official sidecars
* Set Default container to the driver and avoid podmon logs by default
* Fix annotation and remove driverVersion

* [charts/csi-powerflex] Centralize all images to one place dell#263 (dell#311)

* Centralize all images to one place

* Use latest CSI sidecars and default container to driver

* Add default annotation

* Use bleeding edge helm validation action to workaround cosign issue

* [charts/csi-powermax] Container images in one place (dell#309)

* One place to configure all images
* Fix the csi provisioner to use the full name
* Use latest versions of CSI official sidecars

* remove duplicate podmon image

---------

Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: coulof <florian.coulombel@dell.com>
Co-authored-by: alankar-verma <125348121+alankar-verma@users.noreply.github.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: VamsiSiddu-7 <103578883+VamsiSiddu-7@users.noreply.github.com>
Co-authored-by: coulof <49235405+coulof@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>

* [charts/csi-powerscale]: Remove duplicate images (dell#320)

* remove duplicate images

* auth 1.8

* New images location (dell#316)

* [charts/csi-unity]: Update Unity version for CSM 1.9 (dell#322)

* add unity v2.9.0 support

* remove image description

* bump up version (dell#323)

* adding noderoot mount path (dell#324)

* changed sdc version (dell#325)

* sidecars version update for powerstore and powerflex (dell#326)

* updating sidecar image version (dell#328)

* Revert "changed sdc version (dell#325)" (dell#329)

This reverts commit 543cbdc.

* Update VGS version to 1.4.0 (dell#331)

* Powerscale and sidecar version changes (dell#332)

* Powerscale and sidecar version changes

* csi-node-driver-registrar version changed to 2.9.1

* PowerMax 2.9.0 support (dell#321)

* Updating latest sidecars for PowerMax (dell#334)

* [charts/csi-powerflex] Added external access (dell#333)

* external access powerflex

* adding external access in csm chart

* Update image tags for replication (dell#336)

* Reset CSM to release v1.9.0 to main (dell#338)

---------

Signed-off-by: arnchiequ-dell <arnchie.qu@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: VamsiSiddu-7 <103578883+VamsiSiddu-7@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: coulof <49235405+coulof@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: coulof <florian.coulombel@dell.com>
Co-authored-by: Rajshree Khare <69839943+khareRajshree@users.noreply.github.com>
Co-authored-by: aqu-dell <108017114+arnchiequ-dell@users.noreply.github.com>
Co-authored-by: Alik Saring <alik.saring@dell.com>
Co-authored-by: alankar-verma <125348121+alankar-verma@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Peres Kereotubo <118770866+PeresKereotubo@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@coulof coulof coulof approved these changes

@cbartoszDell cbartoszDell cbartoszDell left review comments

@shanduur-dell shanduur-dell shanduur-dell left review comments

@gallacher gallacher gallacher left review comments

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@chaganti-rajitha chaganti-rajitha Awaiting requested review from chaganti-rajitha chaganti-rajitha is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1 niranjan-n1 is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@YianZong YianZong Awaiting requested review from YianZong YianZong is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@atye @coulof @shaynafinocchiaro @gallacher @shanduur-dell @cbartoszDell @KshitijaKakde @alankar-verma @VamsiSiddu-7 @panigs7