Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts/csm-authorization] Add redis as a chart dependency #476

Closed
wants to merge 1 commit into from
Closed

[charts/csm-authorization] Add redis as a chart dependency #476

wants to merge 1 commit into from

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Jul 30, 2024 •
edited
Loading

Is this a new chart?

No

What this PR does / why we need it:

  • Enables chart linting check
  • Adds redis as a chart dependency to Authorization V1 and V2 for linting purposes

Which issue(s) is this PR associated with:

Special notes for your reviewer:

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

Testing:

  • Deployed V1 chart successfully. Able to access redis UI.
  • Deployed V2 chart successfully. Able to access redis UI.

@shaynafinocchiaro shaynafinocchiaro deleted the add-chart-dependencies branch July 31, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atye atye atye approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@chaganti-rajitha chaganti-rajitha Awaiting requested review from chaganti-rajitha chaganti-rajitha is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1 niranjan-n1 is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@YianZong YianZong Awaiting requested review from YianZong YianZong is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaynafinocchiaro @atye