-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts/csi-vxflexos]: Enable SDC by default if not explicitly set #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdawe
requested review from
gallacher,
alikdell,
atye,
hoppea2,
chaganti-rajitha,
coulof,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
taohe1012,
P-Cao,
shanmydell,
baoy1,
YianZong,
forrestxia,
nitesh3108,
rajendraindukuri,
shefali-malhotra,
panigs7,
chimanjain and
HarishH-DELL
as code owners
September 20, 2024 12:21
bharathsreekanth
approved these changes
Sep 20, 2024
falfaroc
approved these changes
Sep 20, 2024
xuluna
approved these changes
Sep 20, 2024
atye
approved these changes
Sep 20, 2024
shaynafinocchiaro
pushed a commit
that referenced
this pull request
Oct 29, 2024
shaynafinocchiaro
pushed a commit
that referenced
this pull request
Oct 30, 2024
shaynafinocchiaro
pushed a commit
that referenced
this pull request
Oct 30, 2024
shaynafinocchiaro
added a commit
that referenced
this pull request
Oct 30, 2024
* [charts/csm-authorization] Add redis as a chart dependency (#480) * add redis as a chart dependency * update depdencies * Enable dependabot for version updates (#479) * Enable dependabot for version updates This PR includes a dependabot configuration file that instructs dependabot to look for version updates to container images in the following charts: - csi-vxflexos - csm-authorization - karavi-observability Other charts can be updated by following a similar pattern to alter the chart values and templates, and then adding the chart to the .github/dependabot file. Tested by running `helm template --dependency-update <chart-name>` and manually inspecting the resulting yaml for proper image specifications. Signed-off-by: Eric Young <eric.young@emc.com> --------- Signed-off-by: Eric Young <eric.young@emc.com> * [charts/csm-authorization-v2.0] Support multiple instances of vault (#485) * support multiple vaults * update comments * fix spacing * Bump the csm-authorization group across 1 directory with 2 updates (#482) * Bump the csm-authorization group across 1 directory with 2 updates Bumps the csm-authorization group with 2 updates in the /charts/csm-authorization directory: openpolicyagent/kube-mgmt and redis. Updates `openpolicyagent/kube-mgmt` from 0.11 to 8.5.7 Updates `redis` from 6.0.8-alpine to 7.4.0-alpine --- updated-dependencies: - dependency-name: openpolicyagent/kube-mgmt dependency-type: direct:production update-type: version-update:semver-major dependency-group: csm-authorization - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-major dependency-group: csm-authorization ... Signed-off-by: dependabot[bot] <support@github.com> * update policy for kube-mgmt to read in for opa * make same updates for v2 * update redis image --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: root <shayna_finocchiaro@dell.com> * Bump the csi-vxflexos group across 1 directory with 3 updates (#483) Bumps the csi-vxflexos group with 3 updates in the /charts/csi-vxflexos directory: sig-storage/csi-provisioner, sig-storage/csi-resizer and sig-storage/csi-node-driver-registrar. Updates `sig-storage/csi-provisioner` from v5.0.1 to v5.0.2 Updates `sig-storage/csi-resizer` from v1.11.1 to v1.11.2 Updates `sig-storage/csi-node-driver-registrar` from v2.10.1 to v2.11.1 --- updated-dependencies: - dependency-name: sig-storage/csi-provisioner dependency-type: direct:production dependency-group: csi-vxflexos - dependency-name: sig-storage/csi-resizer dependency-type: direct:production dependency-group: csi-vxflexos - dependency-name: sig-storage/csi-node-driver-registrar dependency-type: direct:production dependency-group: csi-vxflexos ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Removing commented line from csi-isilon controller yaml. (#487) * Authorization v2 update storage crd with isiPath for powerscale support (#488) * Update storage crd with isiPath * Add description for CR parameters * csi-vxflexos version bump up (#490) * Bump the csi-vxflexos group across 1 directory with 4 updates (#493) Bumps the csi-vxflexos group with 4 updates in the /charts/csi-vxflexos directory: sig-storage/csi-attacher, sig-storage/csi-provisioner, sig-storage/csi-resizer and sig-storage/csi-node-driver-registrar. Updates `sig-storage/csi-attacher` from v4.6.1 to v4.7.0 Updates `sig-storage/csi-provisioner` from v5.0.2 to v5.1.0 Updates `sig-storage/csi-resizer` from v1.11.2 to v1.12.0 Updates `sig-storage/csi-node-driver-registrar` from v2.11.1 to v2.12.0 --- updated-dependencies: - dependency-name: sig-storage/csi-attacher dependency-type: direct:production dependency-group: csi-vxflexos - dependency-name: sig-storage/csi-provisioner dependency-type: direct:production dependency-group: csi-vxflexos - dependency-name: sig-storage/csi-resizer dependency-type: direct:production dependency-group: csi-vxflexos - dependency-name: sig-storage/csi-node-driver-registrar dependency-type: direct:production dependency-group: csi-vxflexos ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump openpolicyagent/kube-mgmt (#492) Bumps the csm-authorization group with 1 update in the /charts/csm-authorization directory: openpolicyagent/kube-mgmt. Updates `openpolicyagent/kube-mgmt` from 8.5.7 to 8.5.8 --- updated-dependencies: - dependency-name: openpolicyagent/kube-mgmt dependency-type: direct:production update-type: version-update:semver-patch dependency-group: csm-authorization ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [charts/csm-authorization-v2.0] Enable dependabot for authorization v2 (#494) * enable dependabot for auth v2 * combine into one * Adding dependabot compatibility for csi-isilon images (#489) * Cherry-picked .github/dependabot.yaml from 6e0b47d (#481) * update isilon images for dependabot * updating dependabot.yaml for isilon * remove trailing spaces * add missing period --------- Co-authored-by: Eric Young <eric.young@dell.com> * Bump openpolicyagent/kube-mgmt (#496) Bumps the csm-authorization group with 1 update in the /charts/csm-authorization-v2.0 directory: openpolicyagent/kube-mgmt. Updates `openpolicyagent/kube-mgmt` from 8.5.7 to 8.5.8 --- updated-dependencies: - dependency-name: openpolicyagent/kube-mgmt dependency-type: direct:production update-type: version-update:semver-patch dependency-group: csm-authorization ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * charts/csi-unity version bump up (#498) * Bump nginxinc/nginx-unprivileged (#484) Bumps the karavi-observability group with 1 update in the /charts/karavi-observability directory: nginxinc/nginx-unprivileged. Updates `nginxinc/nginx-unprivileged` from 1.20 to 1.27 --- updated-dependencies: - dependency-name: nginxinc/nginx-unprivileged dependency-type: direct:production update-type: version-update:semver-minor dependency-group: karavi-observability ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add coordination.k8s.io access for observability (#502) * Update the CRD versions to v1 (#503) * Add dependabot compatibility for csi-powerstore images (#505) * Add dependabot compatibility for csi-powerstore images * Update dependabot.yml * Adding dependabot compatibility for csi-unity (#508) * Adding dependabot compatibility for csi-unity * removing trailing spaces * Bump the csi-powerstore group across 1 directory with 6 updates (#507) Bumps the csi-powerstore group with 6 updates in the /charts/csi-powerstore directory: | Package | From | To | | --- | --- | --- | | sig-storage/csi-attacher | `v4.6.1` | `v4.7.0` | | sig-storage/csi-provisioner | `v5.0.1` | `v5.1.0` | | sig-storage/csi-snapshotter | `v8.0.1` | `v8.1.0` | | sig-storage/csi-resizer | `v1.11.1` | `v1.12.0` | | sig-storage/csi-node-driver-registrar | `v2.10.1` | `v2.12.0` | | sig-storage/csi-external-health-monitor-controller | `v0.12.1` | `v0.13.0` | Updates `sig-storage/csi-attacher` from v4.6.1 to v4.7.0 Updates `sig-storage/csi-provisioner` from v5.0.1 to v5.1.0 Updates `sig-storage/csi-snapshotter` from v8.0.1 to v8.1.0 Updates `sig-storage/csi-resizer` from v1.11.1 to v1.12.0 Updates `sig-storage/csi-node-driver-registrar` from v2.10.1 to v2.12.0 Updates `sig-storage/csi-external-health-monitor-controller` from v0.12.1 to v0.13.0 --- updated-dependencies: - dependency-name: sig-storage/csi-attacher dependency-type: direct:production dependency-group: csi-powerstore - dependency-name: sig-storage/csi-provisioner dependency-type: direct:production dependency-group: csi-powerstore - dependency-name: sig-storage/csi-snapshotter dependency-type: direct:production dependency-group: csi-powerstore - dependency-name: sig-storage/csi-resizer dependency-type: direct:production dependency-group: csi-powerstore - dependency-name: sig-storage/csi-node-driver-registrar dependency-type: direct:production dependency-group: csi-powerstore - dependency-name: sig-storage/csi-external-health-monitor-controller dependency-type: direct:production dependency-group: csi-powerstore ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the csi-vxflexos group across 1 directory with 2 updates (#501) Bumps the csi-vxflexos group with 2 updates in the /charts/csi-vxflexos directory: sig-storage/csi-snapshotter and sig-storage/csi-external-health-monitor-controller. Updates `sig-storage/csi-snapshotter` from v8.0.1 to v8.1.0 Updates `sig-storage/csi-external-health-monitor-controller` from v0.12.1 to v0.13.0 --- updated-dependencies: - dependency-name: sig-storage/csi-snapshotter dependency-type: direct:production dependency-group: csi-vxflexos - dependency-name: sig-storage/csi-external-health-monitor-controller dependency-type: direct:production dependency-group: csi-vxflexos ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the csi-isilon group across 1 directory with 6 updates (#500) Bumps the csi-isilon group with 6 updates in the /charts/csi-isilon directory: | Package | From | To | | --- | --- | --- | | sig-storage/csi-attacher | `v4.6.1` | `v4.7.0` | | sig-storage/csi-provisioner | `v5.0.1` | `v5.1.0` | | sig-storage/csi-snapshotter | `v8.0.1` | `v8.1.0` | | sig-storage/csi-resizer | `v1.11.1` | `v1.12.0` | | sig-storage/csi-node-driver-registrar | `v2.10.1` | `v2.12.0` | | sig-storage/csi-external-health-monitor-controller | `v0.12.1` | `v0.13.0` | Updates `sig-storage/csi-attacher` from v4.6.1 to v4.7.0 Updates `sig-storage/csi-provisioner` from v5.0.1 to v5.1.0 Updates `sig-storage/csi-snapshotter` from v8.0.1 to v8.1.0 Updates `sig-storage/csi-resizer` from v1.11.1 to v1.12.0 Updates `sig-storage/csi-node-driver-registrar` from v2.10.1 to v2.12.0 Updates `sig-storage/csi-external-health-monitor-controller` from v0.12.1 to v0.13.0 --- updated-dependencies: - dependency-name: sig-storage/csi-attacher dependency-type: direct:production dependency-group: csi-isilon - dependency-name: sig-storage/csi-provisioner dependency-type: direct:production dependency-group: csi-isilon - dependency-name: sig-storage/csi-snapshotter dependency-type: direct:production dependency-group: csi-isilon - dependency-name: sig-storage/csi-resizer dependency-type: direct:production dependency-group: csi-isilon - dependency-name: sig-storage/csi-node-driver-registrar dependency-type: direct:production dependency-group: csi-isilon - dependency-name: sig-storage/csi-external-health-monitor-controller dependency-type: direct:production dependency-group: csi-isilon ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * charts/container-storage-modules updated podmon version (#504) * updated podmon version * update replication version * Update Chart.yaml * updated replication versions * updated replication versions * updated replication versions * bump observability version * fix instruction link --------- Co-authored-by: Chiman Jain <chimanjain15@gmail.com> * Add flag to enable or disable the SDC init container (#511) * Bump the csi-unity group across 1 directory with 6 updates (#510) Bumps the csi-unity group with 6 updates in the /charts/csi-unity directory: | Package | From | To | | --- | --- | --- | | sig-storage/csi-attacher | `v4.6.1` | `v4.7.0` | | sig-storage/csi-provisioner | `v5.0.1` | `v5.1.0` | | sig-storage/csi-snapshotter | `v8.0.1` | `v8.1.0` | | sig-storage/csi-resizer | `v1.11.1` | `v1.12.0` | | sig-storage/csi-node-driver-registrar | `v2.10.1` | `v2.12.0` | | sig-storage/csi-external-health-monitor-controller | `v0.12.1` | `v0.13.0` | Updates `sig-storage/csi-attacher` from v4.6.1 to v4.7.0 Updates `sig-storage/csi-provisioner` from v5.0.1 to v5.1.0 Updates `sig-storage/csi-snapshotter` from v8.0.1 to v8.1.0 Updates `sig-storage/csi-resizer` from v1.11.1 to v1.12.0 Updates `sig-storage/csi-node-driver-registrar` from v2.10.1 to v2.12.0 Updates `sig-storage/csi-external-health-monitor-controller` from v0.12.1 to v0.13.0 --- updated-dependencies: - dependency-name: sig-storage/csi-attacher dependency-type: direct:production dependency-group: csi-unity - dependency-name: sig-storage/csi-provisioner dependency-type: direct:production dependency-group: csi-unity - dependency-name: sig-storage/csi-snapshotter dependency-type: direct:production dependency-group: csi-unity - dependency-name: sig-storage/csi-resizer dependency-type: direct:production dependency-group: csi-unity - dependency-name: sig-storage/csi-node-driver-registrar dependency-type: direct:production dependency-group: csi-unity - dependency-name: sig-storage/csi-external-health-monitor-controller dependency-type: direct:production dependency-group: csi-unity ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [charts/csm-authorization-v2.0]: Add OTEL Collector address to storage-service and expose prometheus metrics (#512) * Cherry-picked .github/dependabot.yaml from 6e0b47d (#481) * [charts/csm-authorization-v2.0] Enable dependabot for authorization v2 (#495) * add dependabot config * combine into one * updating dependabot.yaml for isilon (#491) * Add dependabot compatibility for csi-powerstore images (#506) * Add dependabot compatibility for csi-powerstore images * Update dependabot.yml * Adding dependabot compatibility for csi-unity (#509) * Adding dependabot compatibility for csi-unity * Adding dependabot compatibility for csi-unity * Adding dependabot compatibility for csi-unity * add collector address * remove depdendabot --------- Co-authored-by: Eric Young <eric.young@dell.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: aqu-dell <108017114+arnchiequ-dell@users.noreply.github.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com> * Enable SDC by default if not explicitly set (#513) * Add dependabot compatibility for csi-powermax images (#515) * Bump the csi-powermax group across 1 directory with 6 updates (#526) Bumps the csi-powermax group with 6 updates in the /charts/csi-powermax directory: | Package | From | To | | --- | --- | --- | | sig-storage/csi-attacher | `v4.6.1` | `v4.7.0` | | sig-storage/csi-provisioner | `v5.0.1` | `v5.1.0` | | sig-storage/csi-snapshotter | `v8.0.1` | `v8.1.0` | | sig-storage/csi-resizer | `v1.11.1` | `v1.12.0` | | sig-storage/csi-node-driver-registrar | `v2.10.1` | `v2.12.0` | | sig-storage/csi-external-health-monitor-controller | `v0.12.1` | `v0.13.0` | Updates `sig-storage/csi-attacher` from v4.6.1 to v4.7.0 Updates `sig-storage/csi-provisioner` from v5.0.1 to v5.1.0 Updates `sig-storage/csi-snapshotter` from v8.0.1 to v8.1.0 Updates `sig-storage/csi-resizer` from v1.11.1 to v1.12.0 Updates `sig-storage/csi-node-driver-registrar` from v2.10.1 to v2.12.0 Updates `sig-storage/csi-external-health-monitor-controller` from v0.12.1 to v0.13.0 --- updated-dependencies: - dependency-name: sig-storage/csi-attacher dependency-type: direct:production dependency-group: csi-powermax - dependency-name: sig-storage/csi-provisioner dependency-type: direct:production dependency-group: csi-powermax - dependency-name: sig-storage/csi-snapshotter dependency-type: direct:production dependency-group: csi-powermax - dependency-name: sig-storage/csi-resizer dependency-type: direct:production dependency-group: csi-powermax - dependency-name: sig-storage/csi-node-driver-registrar dependency-type: direct:production dependency-group: csi-powermax - dependency-name: sig-storage/csi-external-health-monitor-controller dependency-type: direct:production dependency-group: csi-powermax ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adding Interfaces for disabling SDC dependency on Powerflex NFS Volumes (#528) * Making SDC optional for Powerflex NFS Volumes * Resolve formatting issue * Removed encryption (#533) * [charts/csm-installer] Adding dependabot compatibility for csm-installer images (#532) * adding image tag * csm-installer depedabot yml update * Removing trailing whitespace * add label (#535) * Bump dellemc/csi-powerstore (#521) * Bump the csm-authorization group across 2 directories with 2 updates (#534) * vgs version update (#536) * [installation-wizard/container-storage-modules] Adding dependabot compatibility for installation-wizard charts (#537) * Add dependabot target * Update installation wizard values * Fix linting issues --------- Co-authored-by: Don Khan <don.khan@dell.com> * driver version bump (#540) * updating image references to quay.io (#539) * refer quay.io * fix * fix lint * fixing yaml lint issues * remove csm-installer * linetr fix * driver version bump * reverseproxy chart bump * fixed the linter issue Signed-off-by: Bahubali Jain <bahubali.jain@dell.com> --------- Signed-off-by: Bahubali Jain <bahubali.jain@dell.com> Co-authored-by: shefali-malhotra <kalrashefali10@gmail.com> Co-authored-by: Surya <surya.gupta1@dell.com> Co-authored-by: Bahubali Jain <bahubali.jain@dell.com> Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com> * update auth for 1.12 (#541) * updated replication version (#542) * Update missed replication version updates (#544) * Add disks path to vxflexos node (#545) * Bump dell/container-storage-modules/csi-metadata-retriever (#546) Bumps the container-storage-modules group with 1 update in the /installation-wizard/container-storage-modules directory: dell/container-storage-modules/csi-metadata-retriever. Updates `dell/container-storage-modules/csi-metadata-retriever` from v1.8.0 to v1.9.0 --- updated-dependencies: - dependency-name: dell/container-storage-modules/csi-metadata-retriever dependency-type: direct:production dependency-group: container-storage-modules ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump dell/container-storage-modules/csi-metadata-retriever (#548) Bumps the csi-powerstore group with 1 update in the /charts/csi-powerstore directory: dell/container-storage-modules/csi-metadata-retriever. Updates `dell/container-storage-modules/csi-metadata-retriever` from v1.8.0 to v1.9.0 --- updated-dependencies: - dependency-name: dell/container-storage-modules/csi-metadata-retriever dependency-type: direct:production dependency-group: csi-powerstore ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump dell/container-storage-modules/csi-metadata-retriever (#547) Bumps the csi-isilon group with 1 update in the /charts/csi-isilon directory: dell/container-storage-modules/csi-metadata-retriever. Updates `dell/container-storage-modules/csi-metadata-retriever` from v1.8.0 to v1.9.0 --- updated-dependencies: - dependency-name: dell/container-storage-modules/csi-metadata-retriever dependency-type: direct:production dependency-group: csi-isilon ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: Eric Young <eric.young@emc.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Bahubali Jain <bahubali.jain@dell.com> Co-authored-by: Eric Young <eric.young@dell.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rodrigobassil <115796094+rodrigobassil@users.noreply.github.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: aqu-dell <108017114+arnchiequ-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Harshita Pandey <88329939+harshitap26@users.noreply.github.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com> Co-authored-by: Niranjan N <110103643+niranjan-n1@users.noreply.github.com> Co-authored-by: Chiman Jain <chimanjain15@gmail.com> Co-authored-by: Trevor Dawe <trevor.dawe@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com> Co-authored-by: ChristianAtDell <110482953+ChristianAtDell@users.noreply.github.com> Co-authored-by: aqu-dell <108017114+aqu-dell@users.noreply.github.com> Co-authored-by: mgandharva <124261698+mgandharva@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com> Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: Nitesh-Rewatkar <90749010+nitesh3108@users.noreply.github.com> Co-authored-by: shefali-malhotra <kalrashefali10@gmail.com> Co-authored-by: Surya <surya.gupta1@dell.com> Co-authored-by: Bahubali Jain <bahubali.jain@dell.com> Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com> Co-authored-by: Santhosh Lakshmanan <111809751+santhoshatdell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
This PR fixes the issue when the sdc.enabled field does not exist in values.yaml. We should default the SDC install to true to remain backwards compatible.
The helm template condition is to install the SDC based on following:
If sdc.enabled field is missing or sdc.enabled=true
Which issue(s) is this PR associated with:
Special notes for your reviewer:
Tested by installing the helm chart with a missing sdc.enabled field and by explicitly setting sdc.enabled to true and then false.
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]
) if applicable