[charts/csi-vxflexos] Reduce RBAC requirements for Leases, Secrets, ConfigMaps #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonues : Use k8s & help recommended labels https://helm.sh/docs/chart_best_practices/labels/
coulof
requested review from
HarishH-DELL,
YianZong,
alikdell,
atye,
baoy1,
chaganti-rajitha,
chimanjain,
forrestxia,
gallacher,
hoppea2,
meggm,
niranjan-n1,
nitesh3108,
panigs7,
rajendraindukuri,
shanmydell,
sharmilarama,
shaynafinocchiaro,
shefali-malhotra,
tdawe and
tssushma
as code owners
hoppea2
requested changes
Jan 14, 2025
Collaborator
hoppea2
left a comment
hoppea2
left a comment
There was a problem hiding this comment.
Not for CSM 1.13, pending full testing
Collaborator
Author
|
Won't merge, Engineering is taking care change. @hoppea2, could you had the ticket # or PR here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus : Use k8s & help recommended labels https://helm.sh/docs/chart_best_practices/labels/
Is this a new chart?
No
What this PR does / why we need it:
Needed by JPMC
Which issue(s) is this PR associated with:
KRV-11393
Special notes for your reviewer:
Tested with PodMon, Health
Not tested with Replication and Authorization
cert-csi passed successfully
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable