charts/karavi-observability: Mount powermax-reverseproxy-secret to karavi container. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshitap26
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
chaganti-rajitha,
coulof,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
shanmydell,
baoy1,
YianZong,
forrestxia,
nitesh3108,
rajendraindukuri,
shefali-malhotra,
panigs7,
chimanjain and
HarishH-DELL
as code owners
falfaroc
reviewed
Jan 30, 2025
| # and login credentials. If set to false, the deprecated ConfigMap will be automatically | ||
| # created and used. | ||
| # Default value: false | ||
| useSecret: false |
There was a problem hiding this comment.
question: Is there anyway to reuse the same parameters from the Powermax charts to avoid misconfiguration?
There was a problem hiding this comment.
we might be able to update the chart to add a dependency, like we do with csireverse proxy in the main driver chart
There was a problem hiding this comment.
actually, that might include the whole reverse proxy and try to deploy it 🤔
falfaroc
approved these changes
Jan 30, 2025
lukeatdell
approved these changes
Jan 30, 2025
harshitap26
merged commit 97a66af
into
usr/spark/powermax-secret-feature
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
The changes mount the
powermax-reverseproxy-secretto the karavi-metrics container for the Observability module to read the configuration from the secret in case of useSecret is set to true.Which issue(s) is this PR associated with:
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable