Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing jwt-go from mod file #115

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Removing jwt-go from mod file #115

merged 2 commits into from
Jul 27, 2021

Conversation

hoppea2
Copy link
Collaborator

@hoppea2 hoppea2 commented Jul 27, 2021

Description

As part of CVE-2020-26160 there was a fix in #103 to remove dependencies to jwt-go. There was a lingering entry in go.mod however the library was not in use in the code. This PR removes those lingering references.

Issues

List the issues impacted by this PR:

Issue ID

Checklist:

  • I have performed a self-review of my own changes.

tdawe
tdawe previously approved these changes Jul 27, 2021
@ioeicicdsvc
Copy link
Collaborator

@hoppea2: Thank you for submitting your pull request!

Please make sure you have followed our contributing guidelines. We will review it as soon as possible.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at karavi@dell.com.

@hoppea2
Copy link
Collaborator Author

hoppea2 commented Jul 27, 2021

There is a transitive dependency on jwt-go with the inclusion of viper1.7.0.0, via etcd.
spf13/viper#1126
The jwt-go code is not compiled into the final library

@hoppea2 hoppea2 merged commit 122038f into main Jul 27, 2021
@hoppea2 hoppea2 deleted the IOAD-3966-jwt-go branch July 27, 2021 19:23
LJ-Software pushed a commit that referenced this pull request Aug 17, 2021
* Removing jwt-go from mod file

* dependency on viper1.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants