GetVolumes api for a given tenant #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikdell
requested review from
gallacher,
tdawe,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
IsaiasA1,
aqu-dell and
xuluna
as code owners
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 24, 2023
atye
reviewed
Jan 25, 2023
cmd/proxy-server/main.go
Outdated
| switch scheme { | ||
| case "Bearer": | ||
| var claims token.Claims | ||
| //if token can is valid |
There was a problem hiding this comment.
this comment seems unclear
| } | ||
|
|
||
| log.Printf("volumeList %+v\n", volumeList) | ||
| //TODO: grpc call to storage service to get volume details |
There was a problem hiding this comment.
should this TODO be removed?
There was a problem hiding this comment.
Nopes, it will get removed after integration
sharmilarama
previously approved these changes
Jan 26, 2023
atye
approved these changes
Jan 26, 2023
shaynafinocchiaro
approved these changes
Jan 26, 2023
sharmilarama
approved these changes
Jan 26, 2023
|
run e2e test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new APIs to get volumes from Authorization for a given tenant with valid token.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Manual testing and unit test are added for the functionality.