Volume delete & Storage Response check. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaiasA1
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
aqu-dell and
xuluna
as code owners
alikdell
approved these changes
Feb 13, 2023
shaynafinocchiaro
approved these changes
Feb 13, 2023
|
run e2e test |
atye
reviewed
Feb 14, 2023
| @@ -738,15 +740,14 @@ func volumesHandler(roleServ *roleClientService, storageServ *storageClientServi | |||
| } | |||
|
|
|||
| storageResp, err = storageServ.storageClient.GetPowerflexVolumes(r.Context(), powerflexVolumesRequest) | |||
|
|
|||
| volumeList = append(volumeList, storageResp.Volume...) | |||
|
|
|||
| if err != nil { | |||
| w.WriteHeader(http.StatusInternalServerError) | |||
| log.WithError(err).Println("unable to get powerflex volumes") | |||
| return | |||
There was a problem hiding this comment.
If there is an error, the client will only get the status code and no error message. We should write an error similar to how we do in other places in this handler with web.JSONErrorResponse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a defect where deleted volumes are getting pulled, and a Bad Gateway Error caused by misplaced command.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Tested on my local system with powerflex:
2023/02/13 17:32:28 Starting volume test
Feature: Karavi Authorization
As a consumer of the Karavi Authorization
I want to test karavi authorization
So that they are known to work
Scenario: Show Volumes # features/volume.feature:7
Given Karavi Authorization is available and configured # :1 -> *feature
And I have # :1 -> *feature
When I create a request from with storage capacity # :1 -> *feature
Then I can request a pod to consume # :1 -> *feature
And is bound to storage # :1 -> *feature
And volume is created in backend storage # :1 -> *feature
And dellctl volume list # :1 -> *feature
And I delete the pod and # :1 -> *feature
And is deleted from kubernetes # :1 -> *feature
And volume is deleted from backend storage # :1 -> *feature
Examples:
| storageclass | size | pvc |
| "vxflexos-xfs" | "2Mi" | "pineapple" |
| "vxflexos-xfs" | "4Mi" | "greenapple" |
| "vxflexos-xfs" | "1Mi" | "redapple" |
3 scenarios (3 passed)
30 steps (30 passed)
2m15.085141885s
2023/02/13 17:34:43 Volume test finished
PASS
status 0
ok karavi-testing/karavi-authorization/auth-test 135.154s