Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-725]: Remove k3s from karavictl #227

Merged
merged 29 commits into from
Apr 19, 2023
Merged

[feature-725]: Remove k3s from karavictl #227

merged 29 commits into from
Apr 19, 2023

Conversation

atye
Copy link
Contributor

@atye atye commented Apr 12, 2023 •
edited
Loading

Description

  • Removes k3s calls from role and storage commands so all commands will connect to proxy-server
  • Moved addr and insecure flag to root command
  • Removes karavictl grpc tests and unnecessary test files

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#725

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Existing unit tests and manual tests.

@atye atye changed the title Feature 725 remove k3s calls [feature-725]: Remove k3s from karavictl Apr 12, 2023
@atye atye force-pushed the feature-725-remove-k3s-calls branch from e2b05e2 to b94d9f8 Compare April 13, 2023 23:59
@atye atye marked this pull request as ready for review April 14, 2023 00:10
alikdell
alikdell previously approved these changes Apr 14, 2023
View reviewed changes
IsaiasA1
IsaiasA1 previously approved these changes Apr 17, 2023
View reviewed changes
@atye atye dismissed stale reviews from IsaiasA1 and alikdell via 01fe314 April 18, 2023 01:40
@atye atye force-pushed the feature-725-remove-k3s-calls branch from e0b96b5 to 01fe314 Compare April 18, 2023 01:40
alikdell
alikdell previously approved these changes Apr 18, 2023
View reviewed changes
alikdell
alikdell previously approved these changes Apr 18, 2023
View reviewed changes
@atye atye dismissed stale reviews from alikdell and shaynafinocchiaro via 17c749c April 18, 2023 13:47
alikdell
alikdell previously approved these changes Apr 18, 2023
View reviewed changes
IsaiasA1
IsaiasA1 previously approved these changes Apr 18, 2023
View reviewed changes
@atye atye dismissed stale reviews from IsaiasA1 and alikdell via 7ea4a5f April 18, 2023 21:12
@atye atye force-pushed the feature-725-remove-k3s-calls branch from 17c749c to 7ea4a5f Compare April 18, 2023 21:12
@atye
Copy link
Contributor Author

atye commented Apr 19, 2023

e2e pass

@atye atye merged commit b3bc184 into main Apr 19, 2023
@atye atye deleted the feature-725-remove-k3s-calls branch April 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@IsaiasA1 IsaiasA1 IsaiasA1 left review comments

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@aqu-dell aqu-dell Awaiting requested review from aqu-dell

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atye @alikdell @shaynafinocchiaro @IsaiasA1 @xuluna