Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(linters): added golangci-lint #240

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

shanduur-dell
Copy link
Contributor

@shanduur-dell shanduur-dell commented Aug 2, 2023

Description

This PR adds golangci-lint linters aggregator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

N/A

Special Notes For Your Reviewer:

This was discussed and accepted during meeting on 2023-08-01.

Additional documentation

N/A

Signed-off-by: shanduur-dell <mateusz.urbanek@dell.com>
@csmbot
Copy link
Collaborator

csmbot commented Aug 2, 2023

Can one of the admins verify this patch?

@dell dell deleted a comment from alikdell Aug 7, 2023
@shaynafinocchiaro
Copy link
Collaborator

e2e pass

@shaynafinocchiaro shaynafinocchiaro merged commit 58531cf into main Aug 7, 2023
6 of 7 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the ci-add-golangci-lint branch August 7, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants