Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #303

Closed
wants to merge 7 commits into from
Closed

Update actions #303

wants to merge 7 commits into from

Conversation

mgandharva
Copy link

Description

PR to remove unit test action and consolidate into one.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@csmbot
Copy link
Collaborator

csmbot commented Nov 8, 2024

Can one of the admins verify this patch?

@shaynafinocchiaro shaynafinocchiaro marked this pull request as draft November 8, 2024 19:57
@shaynafinocchiaro
Copy link
Collaborator

Please hold off on this PR. UTs require redis. The current implementation doesn't support this.

@alikdell
Copy link
Collaborator

We have CSM for Authorization V1 deprecation notice (this repo). I am not sure it is good idea to have engineers effort put-in for repo that will go away.

One solution I feel is, we should have checks to make sure no PR get committed that will reduce the current coverage. Keep the checks to maintain at current coverage instead of 80 -> 90 or <80 to 90 for this repo.

@shaynafinocchiaro
Copy link
Collaborator

Closing PR due to future deprecation. Subsequent PRs will continue to maintain previous code coverage numbers.

@shaynafinocchiaro shaynafinocchiaro deleted the mg/update-action branch November 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants