Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade OTEL version to fix known issues #127

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

sharmilarama
Copy link
Collaborator

@sharmilarama sharmilarama commented May 27, 2022

Description

The PR downgrades the OTEL version to last working version, as addressed in patch v.1.1.1

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#288

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test
  • Manual UI verification

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

E2e test results:
--- PASS: Test_Metrics (126.62s) --- PASS: Test_Metrics/Powerflex_ExportNode_Metrics (48.25s) --- PASS: Test_Metrics/Powerflex_Volume_Metrics (64.17s) --- PASS: Test_Metrics/Powerflex_Storage_Pool (14.20s) PASS ok karavi-testing/karavi-metrics/metrics-test 126.655s

@gallacher
Copy link
Collaborator

@sharmilarama, please trigger the e2e tests for this PR. Thanks!

@sharmilarama
Copy link
Collaborator Author

run e2e test

@sharmilarama
Copy link
Collaborator Author

e2e pass

@sharmilarama sharmilarama merged commit fbe70bc into main May 31, 2022
@sharmilarama sharmilarama deleted the otel-downgrade-on-main branch May 31, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants