Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go 1.18 #128

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Update Go 1.18 #128

merged 1 commit into from
Jun 2, 2022

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Jun 2, 2022

Description

This PR updates go mod dependencies for go 1.18

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#257

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Test B

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@hoppea2
Copy link
Collaborator

hoppea2 commented Jun 2, 2022

e2e pass

@hoppea2 hoppea2 merged commit 13c4dcc into main Jun 2, 2022
@shaynafinocchiaro shaynafinocchiaro deleted the update-golang branch June 6, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants