-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade OTEL version to v1.7.0. #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taohe1012
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov and
bjiang27
as code owners
July 5, 2022 09:20
3 tasks
forrestxia
previously approved these changes
Jul 5, 2022
taohe1012
force-pushed
the
feature-356-pflexMetrics-upgrade-otel
branch
from
July 6, 2022 06:51
f779633
to
2ad69f5
Compare
run e2e test |
taohe1012
force-pushed
the
feature-356-pflexMetrics-upgrade-otel
branch
from
July 6, 2022 12:14
2ad69f5
to
868fe01
Compare
run e2e test |
forrestxia
approved these changes
Jul 6, 2022
e2e pass |
alikdell
approved these changes
Jul 6, 2022
shaynafinocchiaro
approved these changes
Jul 6, 2022
sharmilarama
approved these changes
Jul 6, 2022
baoy1
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade OTEL version to v1.7.0:
Note: we upgrade the OpenTelemetry to v1.7.0, and its subpackages to v0.30.0, to use Async UpDownCounter instead of Sync UpDownCounter.
According official reference, UpDownCounter :
For fetching the snapshot of the “current value” is straightforward, use Asynchronous UpDownCounter instead, not Synchronous UpDownCounter.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
PFlex Mgmt UI:
Grafana:
PFlex Mgmt UI:
Grafana:
checked it value:
PFlex Mgmt UI:
Grafana:
Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources