Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade OTEL version to v1.7.0. #130

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

taohe1012
Copy link
Contributor

@taohe1012 taohe1012 commented Jul 5, 2022

Description

upgrade OTEL version to v1.7.0:

  • upgrade otel version to 1.7.0, and its subpackages to v0.30.0;
  • use Async UpDownCounter instead of Sync UpDownCounter;

Note: we upgrade the OpenTelemetry to v1.7.0, and its subpackages to v0.30.0, to use Async UpDownCounter instead of Sync UpDownCounter.

According official reference, UpDownCounter :
For fetching the snapshot of the “current value” is straightforward, use Asynchronous UpDownCounter instead, not Synchronous UpDownCounter.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#454

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Test A: UT tests

ut_result

  • Test B: Grafana Volume IO Metrics: checked it value is consistent with PFlex Mgmt UI's volume value
    PFlex Mgmt UI:

pflexGUI_volume

Grafana:

grafana_volume2

  • Test C: Grafana storage System I/O Metrics by Node: checked it value is consistent with PFlex Mgmt UI's sdc value
    PFlex Mgmt UI:

pflexGUI_sdc_node

Grafana:

grafana_node2

  • Test D: Grafana Storage Pool and Storage Class Capacity:
    checked it value:
  1. Free Capacity and Provisioned is consistent with PFlex Mgmt UI's storage pool value
  2. Total Capacity and Used Capacity are actually TotalLogicalCapacity and LogicalCapacityInUse, they are is consistent with code logic: Total Capacity = usedCapacity + freeCapacity
    PFlex Mgmt UI:

pflexGUI_sp_cap

Grafana:
grafana_storagepool_total2

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@taohe1012
Copy link
Contributor Author

taohe1012 commented Jul 5, 2022

hello everyone, do I need to add some setup to run Image Scanner, or need permission? thanks
image

@taohe1012
Copy link
Contributor Author

e2e passed, all metric tests passed
image

forrestxia
forrestxia previously approved these changes Jul 5, 2022
@taohe1012 taohe1012 force-pushed the feature-356-pflexMetrics-upgrade-otel branch from f779633 to 2ad69f5 Compare July 6, 2022 06:51
@taohe1012
Copy link
Contributor Author

run e2e test

@taohe1012 taohe1012 force-pushed the feature-356-pflexMetrics-upgrade-otel branch from 2ad69f5 to 868fe01 Compare July 6, 2022 12:14
@taohe1012
Copy link
Contributor Author

run e2e test

@alikdell
Copy link
Contributor

alikdell commented Jul 6, 2022

e2e pass

@taohe1012 taohe1012 merged commit 2413846 into main Jul 8, 2022
@taohe1012 taohe1012 deleted the feature-356-pflexMetrics-upgrade-otel branch July 8, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants