Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goscaleio version #164

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Update goscaleio version #164

merged 7 commits into from
Mar 4, 2024

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Mar 1, 2024

Description

Update go clients (goscaleio) to new release version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1091

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

go test -count=1 -cover -race -timeout 30s -short ./...
        github.com/dell/karavi-metrics-powerflex/cmd/metrics-powerflex          coverage: 0.0% of statements                                                              ok      github.com/dell/karavi-metrics-powerflex/internal/entrypoint    4.137s  coverage: 53.1% of statements
        github.com/dell/karavi-metrics-powerflex/internal/k8s/mocks             coverage: 0.0% of statements                                                              ok      github.com/dell/karavi-metrics-powerflex/internal/k8s   1.246s  coverage: 86.4% of statements
        github.com/dell/karavi-metrics-powerflex/opentelemetry/exporters/mocks          coverage: 0.0% of statements                                                              github.com/dell/karavi-metrics-powerflex/internal/service/mocks         coverage: 0.0% of statements
        github.com/dell/karavi-metrics-powerflex/opentelemetry/exporters                coverage: 0.0% of statements
ok      github.com/dell/karavi-metrics-powerflex/internal/service       2.132s  coverage: 94.1% of statements

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@csmbot
Copy link
Collaborator

csmbot commented Mar 1, 2024

Can one of the admins verify this patch?

alikdell
alikdell previously approved these changes Mar 1, 2024
@atye
Copy link
Contributor

atye commented Mar 4, 2024

e2e pass

@xuluna xuluna merged commit e1e876f into main Mar 4, 2024
8 checks passed
@xuluna xuluna deleted the luna/update-release branch March 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants