Update max supported versions for CSM 1.8. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| verify_k8s_versions "1.25" "1.27" | ||
| verify_openshift_versions "4.9" "4.12" | ||
| verify_k8s_versions "1.25" "1.28" | ||
| verify_openshift_versions "4.9" "4.13" |
There was a problem hiding this comment.
I was of the impression that we usually also increment the minimal version. Can you check with others?
verify_k8s_versions "1.26" "1.28"
verify_openshift_versions "4.10" "4.13"
There was a problem hiding this comment.
Incremented minimum version.
harshaatdell
previously approved these changes
Aug 28, 2023
|
Submitting PR. Will test with Openshift once resources are available. |
donatwork
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
Sahiba-Gupta,
aqu-dell,
jackieung-dell,
taohe1012,
P-Cao,
baoy1,
YianZong,
forrestxia and
anandrajak1
as code owners
santhoshatdell
approved these changes
Aug 28, 2023
harshaatdell
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Note that I only tested the version checks. Need the correct Helm chart for successful install.