Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated go module to 1.23 #209

Closed
wants to merge 12 commits into from
Closed

Updated go module to 1.23 #209

wants to merge 12 commits into from

Conversation

niranjan-n1
Copy link
Contributor

@niranjan-n1 niranjan-n1 commented Sep 23, 2024 •
edited
Loading

Description

  1. Updated go.mod and dependencies
  2. Fixed go lint issues

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

image

  • Ran make unit-test

image
image

  • Built image and ran short integration test against the image

image

@niranjan-n1 niranjan-n1 self-assigned this Sep 26, 2024
@niranjan-n1 niranjan-n1 marked this pull request as ready for review September 26, 2024 09:45
@niranjan-n1 niranjan-n1 changed the title Pvt/niranjan update go modules Update go module to 1.23 Sep 26, 2024
@niranjan-n1 niranjan-n1 changed the title Update go module to 1.23 Updated go module to 1.23 Sep 26, 2024
@niranjan-n1 niranjan-n1 deleted the pvt/Niranjan-update-go-modules branch September 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic KerryKovacevic is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

Assignees

@niranjan-n1 niranjan-n1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niranjan-n1