Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(linters): added golangci-lint #134

Merged
merged 2 commits into from
Aug 22, 2023
Merged

ci(linters): added golangci-lint #134

merged 2 commits into from
Aug 22, 2023

Conversation

shanduur-dell
Copy link
Contributor

@shanduur-dell shanduur-dell commented Aug 2, 2023 •
edited
Loading

Description

This PR adds golangci-lint linters aggregator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

N/A

Special Notes For Your Reviewer:

This was discussed and accepted during meeting on 2023-08-01.

Additional documentation

N/A

@shanduur-dell
ci(linters): added golangci-lint
8a4c7af 
Signed-off-by: shanduur-dell <mateusz.urbanek@dell.com>
@csmbot
Copy link
Collaborator

csmbot commented Aug 2, 2023

Can one of the admins verify this patch?

harshaatdell
harshaatdell previously approved these changes Aug 2, 2023
View reviewed changes
donatwork
donatwork previously approved these changes Aug 4, 2023
View reviewed changes
@anandrajak1
Copy link

e2e pass

1 similar comment
@anandrajak1
Copy link

e2e pass

@anandrajak1
Copy link

e2e pass

@anandrajak1 anandrajak1 reopened this Aug 21, 2023
@anandrajak1
Copy link

e2e pass

@anandrajak1 anandrajak1 reopened this Aug 21, 2023
@anandrajak1
Copy link

e2e pass

@anandrajak1
Copy link

e2e pass

@anandrajak1 anandrajak1 reopened this Aug 21, 2023
@anandrajak1
Copy link

e2e pass

@anandrajak1
Copy link

e2e pass

@anandrajak1 anandrajak1 reopened this Aug 21, 2023
@anandrajak1
Copy link

e2e pass

2 similar comments
@anandrajak1
Copy link

e2e pass

@hoppea2
Copy link
Collaborator

hoppea2 commented Aug 22, 2023

e2e pass

@donatwork
Use Trivy for scans
e173761 
Azure tool is deprecated so switching to Trivy.
@donatwork donatwork dismissed stale reviews from harshaatdell and themself via e173761 August 22, 2023 16:10
anandrajak1
anandrajak1 approved these changes Aug 22, 2023
View reviewed changes
Copy link

@anandrajak1 anandrajak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e pass

@hoppea2
Copy link
Collaborator

hoppea2 commented Aug 22, 2023

e2e pass

@hoppea2 hoppea2 merged commit 601cbfb into main Aug 22, 2023
6 of 7 checks passed
@donatwork donatwork deleted the ci-add-golangci-lint branch August 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@harshaatdell harshaatdell harshaatdell approved these changes

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@YianZong YianZong Awaiting requested review from YianZong YianZong is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shanduur-dell @csmbot @anandrajak1 @hoppea2 @donatwork @harshaatdell