Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common base image #144

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Use common base image #144

merged 1 commit into from
Nov 8, 2023

Conversation

tdawe
Copy link
Collaborator

@tdawe tdawe commented Nov 8, 2023

Description

Use common base image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1031

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image using common base image

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@csmbot
Copy link
Collaborator

csmbot commented Nov 8, 2023

Can one of the admins verify this patch?

@tdawe
Copy link
Collaborator Author

tdawe commented Nov 8, 2023

run e2e test

@tdawe tdawe merged commit 0bae103 into main Nov 8, 2023
8 checks passed
@tdawe tdawe deleted the use-common-base-image branch November 8, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AronAtDell AronAtDell AronAtDell approved these changes

@gallacher gallacher gallacher approved these changes

@donatwork donatwork donatwork approved these changes

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@YianZong YianZong Awaiting requested review from YianZong YianZong is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tdawe @csmbot @donatwork @gallacher @AronAtDell