Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mockgen to latest in GitHub action #155

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Update mockgen to latest in GitHub action #155

merged 3 commits into from
Aug 16, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Aug 16, 2024

Description

Update mockgen to latest in GitHub action

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Successful GitHub action run

@csmbot
Copy link
Collaborator

csmbot commented Aug 16, 2024

Can one of the admins verify this patch?

donatwork
donatwork previously approved these changes Aug 16, 2024
@AronAtDell
Copy link

@chimanjain - What is the linting error? Is it addressed? Thanks!

@donatwork
Copy link
Contributor

@chimanjain - What is the linting error? Is it addressed? Thanks!

Two days ago a new version of golangci-lint was released, 1.60.1. This added a new check and flags the way we were logging. In some older code the call to fmt.Errorf uses a function to return the format parameters. It is in a few other drivers as well. The previous version of the linter did not flag this.

@AronAtDell
Copy link

@donatwork - so we fixed the latest flagged issue with linting?

@donatwork
Copy link
Contributor

The repo has v4 of the linter action. There is v5 which would have failed the PR build. Chiman, could you please also update to v5 of the linter?

uses: golangci/golangci-lint-action@v5

@chimanjain
Copy link
Contributor Author

Thanks @AronAtDell and @donatwork for pointing the linting error. Previously I checked whether all the github action ran successfully and even the github action for golangci lint was successful, It was missed from my part. Updated the golangci-lint-action to v5.

@AronAtDell
Copy link

@chimanjain - Thanks! I saw that the actions all passed previously. The good thing is that we did not ignore the issues in the PR and you addressed them. Appreciate your help and attention to these details. Have a good weekend! Thanks @donatwork !

@chimanjain chimanjain merged commit 9874860 into main Aug 16, 2024
7 checks passed
@chimanjain chimanjain deleted the upd-mockgen branch August 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants