-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mockgen to latest in GitHub action #155
Conversation
Can one of the admins verify this patch? |
@chimanjain - What is the linting error? Is it addressed? Thanks! |
Two days ago a new version of golangci-lint was released, 1.60.1. This added a new check and flags the way we were logging. In some older code the call to fmt.Errorf uses a function to return the format parameters. It is in a few other drivers as well. The previous version of the linter did not flag this. |
@donatwork - so we fixed the latest flagged issue with linting? |
The repo has v4 of the linter action. There is v5 which would have failed the PR build. Chiman, could you please also update to v5 of the linter? uses: golangci/golangci-lint-action@v5 |
Thanks @AronAtDell and @donatwork for pointing the linting error. Previously I checked whether all the github action ran successfully and even the github action for golangci lint was successful, It was missed from my part. Updated the golangci-lint-action to |
@chimanjain - Thanks! I saw that the actions all passed previously. The good thing is that we did not ignore the issues in the PR and you addressed them. Appreciate your help and attention to these details. Have a good weekend! Thanks @donatwork ! |
Description
Update mockgen to latest in GitHub action
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration