Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP use in OIM HA environment #2628

Draft
wants to merge 4 commits into
base: pub/new_architecture
Choose a base branch
from

Conversation

Coleman-Trader
Copy link

@Coleman-Trader Coleman-Trader commented Mar 25, 2025

Description of the Solution

Utilizing the VIP as the admin IP when OIM HA is enabled.

Suggested Reviewers

If you wish to suggest specific reviewers for this solution, please include them in this section. Be sure to include the @ before the GitHub username.
@priti-parate
@abhishek-sa1

@Omnia-svc
Copy link
Collaborator

Can one of the admins verify this patch?

hosts: oim
connection: ssh
gather_facts: false
tags: deploy_containers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this flow has been changed? if this is moved resources will create early and containers will be restarted? are we splitting resources and pcs container deployment separately?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The containers are already deployed at this point, so deploying the pcs container before the pulp config allows us to use the VIP with the pulp configuration. As of right now, I kept all resources together since I think with this flow we don't need to split.

@@ -18,12 +18,13 @@ nodelist {
}
{% if hostvars['localhost']['oim_ha_data'].ansible_facts.oim_ha.enable_oim_ha %}
{%- for node_details in hostvars['localhost']['oim_ha_data'].ansible_facts.oim_ha.passive_nodes.node_details %}
{% if node_details.ADMIN_IP is defined %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why admin_ip is capital here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition in the high_availability_config is capitalized:
node_details:
- {SERVICE_TAG : ",HOSTNAME: "",ADMIN_MAC: "",ADMIN_IP: "",BMC_IP: ""}

images_directory_path: "{{ oim_shared_path }}/omnia/images"
read_write_mode: "0644"
container_tag: "latest"
container_tar_file: "omnia_images.tar"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all container images will be stored in single tar file? we need to check omnia_kubespray based on k8s check in software_config.json

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with podman 2.2 they support "-m" for multi-image saves. Will add the check for kubespray.

- name: Set OIM admin IP to virtual IP if OIM HA is enabled
when: enable_oim_ha
ansible.builtin.set_fact:
network_data: "{{ network_data | combine(update_data, recursive=true) }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of overriding the input value override admin ip and update the place using the fqdn path with admin_ip


# Usage: omnia_pcs_setup.js
container_tar_file: "omnia_images.tar"
container_images_path: "{{ oim_shared_path }}/omnia/images/{{ container_tar_file }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update images folder in omnia_startup.sh cleanup flow

state: absent

- name: Save container images
ansible.builtin.command: "podman save -m -o {{ images_directory_path }}/{{ container_tar_file }} {{ container_images }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants