Improved score

dell · Jan 15, 2025 · 7983856 · 7983856
1 parent d2bd4ad
commit 7983856
Show file tree

Hide file tree

Showing 6 changed files with 2,694 additions and 2,687 deletions.
diff --git a/ProgrammersGuideExamples/file_tree_quota_examples.py b/ProgrammersGuideExamples/file_tree_quota_examples.py
@@ -22,7 +22,8 @@
 print(QUOTA)
 
 # Get treequota list
-filter_dict = {"id": "eq.{0}".format(QUOTA["id"])}
+quota_id = QUOTA["id"]
+filter_dict = {"id": f"eq.{quota_id}"}
 QUOTA_LIST = CONN.provisioning.get_file_tree_quotas(filter_dict=filter_dict)
 print(QUOTA_LIST)
 

diff --git a/ProgrammersGuideExamples/file_user_quota_examples.py b/ProgrammersGuideExamples/file_user_quota_examples.py
@@ -21,7 +21,8 @@
 print(QUOTA)
 
 # Get userquota list
-filter_dict = {"id": "eq.{0}".format(QUOTA["id"])}
+quota_id = QUOTA["id"]
+filter_dict = {"id": f"eq.{quota_id}"}
 QUOTA_LIST = CONN.provisioning.get_file_user_quotas(filter_dict=filter_dict)
 print(QUOTA_LIST)
 

diff --git a/PyPowerStore/client.py b/PyPowerStore/client.py
@@ -221,9 +221,8 @@ def fetch_response(
             headers.update(auth_headers)
 
         LOG.debug(
-            "Request's http_method: '%s' url: '%s' payload: '%s' "
-            "querystring: '%s' myrange: '%s'"
-            % (http_method, url, payload, querystring, myrange),
+            "Request's http_method: '%s' url: '%s' payload: '%s' querystring: '%s' myrange: '%s'"
+            , http_method, url, payload, querystring, myrange
         )
         if myrange:
             headers["Range"] = myrange
@@ -432,7 +431,8 @@ def request(self, http_method, url, payload=None, querystring=None, all_pages=No
             ) from exception
         except Timeout as exception:
             LOG.error(str(exception))
-            raise PowerStoreException(PowerStoreException.TIMEOUT_ERROR, str(exception)) from exception
+            raise PowerStoreException(PowerStoreException.TIMEOUT_ERROR, str(exception)
+                                      ) from exception
         except OSError as exception:
             LOG.error(str(exception))
             raise PowerStoreException(PowerStoreException.SOCKET_ERR, str(exception)) from exception
diff --git a/PyPowerStore/configuration.py b/PyPowerStore/configuration.py
@@ -1426,7 +1426,8 @@ def modify_security_config(self, security_config_id, protocol_mode):
         :rtype: None
         """
         LOG.info(
-            f"Modify security config properties: '{security_config_id}' with params '{protocol_mode}'",
+            f"Modify security config properties: \
+                '{security_config_id}' with params '{protocol_mode}'",
         )
 
         payload = {}
@@ -1515,7 +1516,8 @@ def modify_destination_email_details(self, email_id, modify_parameters):
         :rtype : None
         """
         LOG.info(
-            f"Modifying destination email properties: '{email_id}' with params '{modify_parameters}'",
+            f"Modifying destination email properties: \
+                '{email_id}' with params '{modify_parameters}'",
         )
 
         email_url = constants.MODIFY_EMAIL_URL
@@ -1633,7 +1635,8 @@ def modify_smtp_config_details(self, smtp_id, modify_parameters):
         :rtype : None
         """
         LOG.info(
-            f"Modifying SMTP configuration properties: '{smtp_id}' with params '{modify_parameters}'",
+            f"Modifying SMTP configuration properties: \
+                '{smtp_id}' with params '{modify_parameters}'",
         )
 
         smtp_url = constants.MODIFY_SMTP_URL
@@ -1933,7 +1936,8 @@ def get_remote_support_contact_list(self, filter_dict=None, all_pages=None):
         :rtype: list[dict]
         """
         LOG.info(
-            f"Getting all remote support contact with filter: '{filter_dict}' and all_pages: '{all_pages}'",
+            f"Getting all remote support contact with filter: \
+                '{filter_dict}' and all_pages: '{all_pages}'",
         )
         if helpers.is_foot_hill_or_higher():
             querystring = helpers.prepare_querystring(constants.SELECT_ID, filter_dict)
@@ -1999,7 +2003,8 @@ def modify_remote_support_contact_details(
         :rtype : None
         """
         LOG.info(
-            f"Modifying remote support contact : '{remote_support_contact_id}' with params '{modify_parameters}'",
+            f"Modifying remote support contact : \
+                '{remote_support_contact_id}' with params '{modify_parameters}'",
         )
         if helpers.is_foot_hill_or_higher():
             remote_support_contact_url = constants.MODIFY_REMOTE_SUPPORT_CONTACT_URL
@@ -2475,7 +2480,7 @@ def get_storage_container_destination_list(self, filter_dict=None, all_pages=Non
         """
         LOG.info(
             "Getting storage containers destination with filter: '%s' "
-            "and all_pages: %s" % (filter_dict, all_pages),
+            "and all_pages: %s" , filter_dict, all_pages
         )
         querystring = helpers.prepare_querystring(
             constants.STORAGE_CONTAINER_DETAILS_DESTINATION_QUERY, filter_dict,
@@ -2502,7 +2507,7 @@ def get_storage_container_destination_details(
         """
         LOG.info(
             "Getting storage container destination details by "
-            "ID: '%s'" % storage_container_destination_id,
+            "ID: '%s'" , storage_container_destination_id
         )
 
         return self.config_client.request(
@@ -2536,7 +2541,7 @@ def delete_storage_container_destination(self, storage_container_destination_id)
         """
         LOG.info(
             "Deleting storage container destination with "
-            "id: '%s'" % storage_container_destination_id,
+            "id: '%s'" , storage_container_destination_id,
         )
         return self.config_client.request(
             constants.DELETE,

diff --git a/PyPowerStore/protection.py b/PyPowerStore/protection.py
@@ -839,7 +839,7 @@ def get_filesystem_snapshot_details_by_name(
             )
         LOG.info(
             "Getting filesystem snapshot: '%s' details by "
-            "nasserver id: '%s'" % (snapshot_name, nas_server_id),
+            "nasserver id: '%s'" , snapshot_name, nas_server_id
         )
         return self.provisioning.get_filesystem_by_name(
             filesystem_name=snapshot_name, nas_server_id=nas_server_id,
@@ -1058,7 +1058,7 @@ def get_replication_sessions(self, filter_dict=None, all_pages=False):
         """
         LOG.info(
             "Getting replication sessions with filter: '%s' and "
-            "all_pages: '%s'" % (filter_dict, all_pages),
+            "all_pages: '%s'" , filter_dict, all_pages,
         )
         querystring = helpers.prepare_querystring(constants.SELECT_ID, filter_dict)
         LOG.info("Querystring: '%s'", querystring)
@@ -1190,7 +1190,7 @@ def get_replication_groups(self, filter_dict=None, all_pages=False):
         """
         LOG.info(
             "Getting replication groups with filter: '%s' and "
-            "all_pages: %s" % (filter_dict, all_pages),
+            "all_pages: %s" , filter_dict, all_pages,
         )
         querystring = helpers.prepare_querystring(
             constants.REPLICATION_GROUP_QUERY, filter_dict,