Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform framework plugin to v1.4.2 #80

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

RayLiu7
Copy link
Contributor

@RayLiu7 RayLiu7 commented Oct 31, 2023

Description

Terraform framework plugin 1.4.0 doesn't work with Terraform 1.6 due to a know issue (fixed in 1.4.1) and causes all FT cases to fail (Err: Data Source Type Not Found or Resource Type Not Found).
Issue: hashicorp/terraform-plugin-framework#853
Upgrade its version to the latest 1.4.2 to solve the problem.
Pipeline: https://osj-sio-03-prd.cec.lab.emc.com/view/Terraform/job/Terraform-Pipelines/job/tf-manual/747/Summary_20Report/
The failed NFS export cases and Snapshot cases need feature FT owner's further investigation.

ISSUE TYPE

  • Bugfix Pull Request
OUTPUT

Pipeline: https://osj-sio-03-prd.cec.lab.emc.com/view/Terraform/job/Terraform-Pipelines/job/tf-manual/747/Summary_20Report/

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Oct 31, 2023

run e2e test

2 similar comments
@forrestxia
Copy link
Collaborator

run e2e test

@forrestxia
Copy link
Collaborator

run e2e test

@forrestxia
Copy link
Collaborator

e2e pass

@forrestxia
Copy link
Collaborator

@RayLiu7 need signed commit

@RayLiu7 RayLiu7 force-pushed the upgrade-tf-fw-version branch from d7f660e to d014332 Compare November 1, 2023 02:39
@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Nov 1, 2023

run e2e test

@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Nov 1, 2023

e2e pass

@RayLiu7 RayLiu7 merged commit 23124f5 into main Nov 1, 2023
6 checks passed
@RayLiu7 RayLiu7 deleted the upgrade-tf-fw-version branch November 1, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants