Add bios change job wait using StateChangeConf method

[brutus333]

Fixes #18

Signed-off-by: Virgil Chereches virgil.chereches@gmail.com

SUMMARY

Closes #18

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

redfish_bios

ADDITIONAL INFORMATION

The provider should wait until bios change job has finished and return a failure if the job fails.
The right way to implement this wait is by using TF SDK StateChangeConf method - other providers such as GCP and AWS ones are using this method whenever the provider should wait after some events during create/update of a resource.

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

[brutus333]

This is a first attempt to fix the provider - as of now the code does not deal with error conditions like loosing access to iDRAC, job hanging and other exceptions that might occur.
I propose to open a different issue to deal with that part.

[grantcurell]

@brutus333 I have to know - did you go to Ohio State? Or is the name unrelated and this question makes no sense?

[brutus333]

@brutus333 I have to know - did you go to Ohio State? Or is the name unrelated and this question makes no sense?

@grantcurell : no, not at all. Is this a kind of joke?

[anupamaloke]

@brutus333 my sincere apologies for the delay in review. I will be taking a look and provide comments, if any.

[grantcurell]

@brutus333 I have to know - did you go to Ohio State? Or is the name unrelated and this question makes no sense?

@grantcurell : no, not at all. Is this a kind of joke?

Not a joke hahaha sorry I added to the confusion. In my area of the US, Brutus is an uncommon name and usually whenever you see it, it refers to the mascot of a large school nearby. It is particularly popular in user names

[anupamaloke]

LGTM