fix uneven heads issue#25
Merged
delock merged 1 commit intodelock:gma/run-opt-branchfrom Oct 31, 2023
Merged
Conversation
delock
reviewed
Oct 31, 2023
deepspeed/module_inject/tp_shard.py
Outdated
| @@ -20,16 +20,13 @@ def get_num_kv_heads(): | |||
| def get_shard_size(total_size, mp_size, rank=None): | |||
| global num_kv_heads | |||
| # When we have num_kv_heads defined, uneven division is possible, otherwise enforce even division | |||
Owner
There was a problem hiding this comment.
change 'otherwise enforce even division' to 'otherwise enforce near even division'
Yejing-Lai
force-pushed
the
lyj/fix_uneven_heads
branch
from
9c0aff6 to
26bb7c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make AutoTP work when split_shape % num_kv_heads != 0.