Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors when restarting WebApp in Docker #23

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

johannesduesing
Copy link
Contributor

Reason for this PR
When a docker image is built from the WebApps build.sbt, and containers are being deployed, these containers cannot be restarted. Once stopped and started again (or after calling docker restart), the container logs will show the message

This application is already running (Or delete /usr/share/odin/RUNNING_PID file).

and the container will exit immediately.

Solution
Based on this comment, i have change the configuration setting for the PID file. This fixed the problem, meaning i was able to stop, start and restart WebApp containers.

@johannesduesing johannesduesing self-assigned this Nov 16, 2018
@ghost ghost added the review label Nov 16, 2018
@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #23 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #23   +/-   ##
=====================================
  Coverage        0%    0%           
=====================================
  Files           10    10           
  Lines          234   234           
  Branches        23    23           
=====================================
  Misses         234   234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdac1a5...4b03380. Read the comment docs.

Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bhermann bhermann merged commit 3a5b352 into develop Nov 16, 2018
@ghost ghost removed the review label Nov 16, 2018
@bhermann bhermann deleted the bugfix/dockerRestart branch November 16, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants