Skip to content

Access violation error in all overloads of SumOfLogs #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delphidabbler opened this issue Jan 13, 2025 · 2 comments
Closed

Access violation error in all overloads of SumOfLogs #46

delphidabbler opened this issue Jan 13, 2025 · 2 comments
Assignees
Labels
bug Something isn't working completed Issue completed and committed to develop. To be closed on next release

Comments

@delphidabbler
Copy link
Owner

If a non-positive element of any array passed to SumOfLogs an exception is supposed to be raised. But we get an access violation instead. This is because the code is:

raise SysUtils.EArgumentOutOfRangeException(sNotPositive);

instead of

raise SysUtils.EArgumentOutOfRangeException.Create(sNotPositive);

i.e. the Create method call is missing!

@delphidabbler delphidabbler self-assigned this Jan 13, 2025
@delphidabbler delphidabbler added bug Something isn't working accepted Issue will be actioned labels Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Considering in Code Snippets Jan 13, 2025
@delphidabbler delphidabbler moved this from Considering to Accepted in Code Snippets Jan 13, 2025
@delphidabbler delphidabbler added this to the Next Release milestone Jan 13, 2025
@delphidabbler
Copy link
Owner Author

This bug became apparent while implementing issue #31.

The fix has been completed on a local repo and will be pushed when issue #31 is pushed.

@delphidabbler delphidabbler added completed Issue completed and committed to develop. To be closed on next release and removed accepted Issue will be actioned labels Jan 13, 2025
@delphidabbler delphidabbler moved this from Accepted to Completed in Code Snippets Jan 13, 2025
@delphidabbler
Copy link
Owner Author

Implemented by merge commit 5c7623f

@delphidabbler delphidabbler removed this from the Next Release milestone Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed Issue completed and committed to develop. To be closed on next release
Projects
Status: Completed
Development

No branches or pull requests

1 participant