Skip to content

Centralise release version numbers in one file #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
delphidabbler opened this issue Dec 16, 2022 · 1 comment
Closed

Centralise release version numbers in one file #75

delphidabbler opened this issue Dec 16, 2022 · 1 comment
Assignees
@delphidabbler
Labels
completed Work has been completed on this issue and changes have been committed to `develop` branch.. refactoring This issue requires refactoring only, not a change in functionality

Comments

@delphidabbler
Copy link
Owner

At present, file and product release version numbers are common to both the standard and portable editions of CodeSnip, but they have to be entered separately in VCodeSnip.vi and VCodeSnipPortable.vi.

This leaves room for error.

So create a new VERSION file that contains versions and include those values in the .vi files as macros.
@delphidabbler delphidabbler self-assigned this Dec 16, 2022
@delphidabbler delphidabbler added accepted Accepted for implementation / fixing refactoring This issue requires refactoring only, not a change in functionality labels Dec 16, 2022
@delphidabbler
Copy link
Owner Author

Actually extracted some common string file info into macros too.

Named macro file VersionInfo.vi-inc instead of VERSION.

@delphidabbler delphidabbler added completed Work has been completed on this issue and changes have been committed to `develop` branch.. and removed accepted Accepted for implementation / fixing labels Dec 16, 2022
delphidabbler added a commit that referenced this issue Dec 16, 2022
@delphidabbler
Extract common version information into include file
e1ce753 
Version information from VCodeSnip.vi and VCodeSnipPortable.vi that is
common to both files was extracted into the VersionInfo.vi-inc file as
macro definitions. The macros were then imported into to .vi files.

Changed file description. Renamed program from historic "Viewer" (that
dates back to v1!) to "Repository". Also added "Standard Version" for
standard version to match "Portable Version" that was already appended
to file description in portable version.

As a side effect, this commit fixes problem of rendering copyright
symbol, because VIEd handles UTF-8 correctly in macro import files but
not in .vi files!

Closes #75
@github-project-automation github-project-automation bot moved this to Considering in CodeSnip May 23, 2023
@delphidabbler delphidabbler moved this from Considering to Done - released in CodeSnip May 23, 2023
@delphidabbler delphidabbler removed this from CodeSnip Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delphidabbler delphidabbler

Labels
completed Work has been completed on this issue and changes have been committed to `develop` branch.. refactoring This issue requires refactoring only, not a change in functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delphidabbler