-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up definitions for glyphs from nerd-fonts #67
Comments
@yuki-yano I have created the git checkout feature/add_codicons_patched
brew install --build-from-source ./sfmono-square.rb This installs SF Mono Square lspkind settings local lspkind_format = require("lspkind").cmp_format {
mode = "symbol_text",
maxwidth = maxwidth,
symbol_map = {
Text = "", -- 0xFEA93
Method = "", -- 0xFEA8C
Function = "", -- 0xFEA8C
Constructor = "", -- 0xFEA8C
Field = "", -- 0xFEB5F
Variable = "", -- 0xFEA88
Class = "", -- 0xFEB5B
Interface = "", -- 0xFEB61
Module = "", -- 0xFEA8B
Property = "", -- 0xFEB65
Unit = "", -- 0xFEA96
Value = "", -- 0xFEA95
Enum = "", -- 0xFEA95
Keyword = "", -- 0xFEB62
Snippet = "", -- 0xFEB66
Color = "", -- 0xFEB5C
File = "", -- 0xFEA7B
Reference = "", -- 0xFEA94
Folder = "", -- 0xFEA83
EnumMember = "", -- 0xFEA95
Constant = "", -- 0xFEB5D
Struct = "", -- 0xFEA91
Event = "", -- 0xFEA86
Operator = "", -- 0xFEB64
TypeParameter = "", -- 0xFEA92
},
} How do you think about this patch? |
I force-pushed the tag |
Finally I released |
Updated. I fix the table above to solve this problem below.
|
Updated again. I found a problem. SF Mono has some glyphs on PUA that Material overwrites. I move these glyphs below to the area outside BMP.
So SF Mono Square v2.0.0 (still unreleased) uses this codepoints.
|
Now ryanoasis/nerd-fonts#365 has been closed! According to that, I will upgrade SF Mono Square to catch up nerd-fonts v3's codepoints. |
nerd-fonts v3.0.0 has been released! So I will update SF Mono Square to use the latest codepoints. PR is here → #88
Now SF Mono Square v3 uses completely the same codepoints as the ones in nerd-fonts v3. Here is the difference SF Mono Square v2 & v3 below.
I'm creating a migration script named # convert all files below the current directory
# from v2 => v3 (default values)
% convert_codepoints .
# specify versions
% convert_codepoints -f v1 -t v3 .
# also you can convert between nerd_fonts versions
% convert_codepoints -f nerd_fonts_v2 -t nerd_fonts_v3 . Here is an example that I executed this in my dotfiles. An example for
|
Now SF Mono Square has glyphs from nerd-fonts.
There are some differences.
Here are glyphs on Private Use Areas in current.
So there are some plans to place Codeicons glyphs (#66) (396 glyphs).
I think either plan 2 or plan 3 is better. How do you think, @yuki-yano ?
I have written this issue up to here, and known a new PR is filed in nerd-fonts.
We maybe should proceed this discussion with contact to there.
The text was updated successfully, but these errors were encountered: