Skip to content

Conversation

@pcd1193182
Copy link

Now that the stacks and threads commands have been properly separated into the kernel module, we can write a userland implementation of these commands. These implementations are heavily based on the originals, but using the generic drgn API that doesn't assume it can access the thread's object parameter. As a result, we have to lose the module and state filters on the stacks.

@pcd1193182 pcd1193182 force-pushed the uthread branch 2 times, most recently from dbfdc2e to b5127bb Compare March 20, 2023 21:37
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #321 (dbfdc2e) into 6.0/stage (f5e1943) will decrease coverage by 1.99%.
The diff coverage is 36.75%.

❗ Current head dbfdc2e differs from pull request most recent head b5127bb. Consider uploading reports for the commit b5127bb to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##           6.0/stage     #321      +/-   ##
=============================================
- Coverage      87.81%   85.83%   -1.99%     
=============================================
  Files             64       66       +2     
  Lines           2742     2859     +117     
=============================================
+ Hits            2408     2454      +46     
- Misses           334      405      +71     
Impacted Files Coverage Δ
sdb/commands/ustacks.py 31.13% <31.13%> (ø)
sdb/commands/uthreads.py 90.90% <90.90%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ahrens ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test case for this?

@sdimitro
Copy link
Contributor

sdimitro commented Mar 22, 2023

@ahrens @pcd1193182

In terms of testing we can add a userland core dump to our test suite the same way we have kernel ones but the testing infrastructure will need to be adjusted a bit more. I can slowly start working on this. In the meantime I'm good with merging this.

EDIT: Paul if you have a core dump that you used for development, you can try archiving it with savedump and send me over the file.

@pcd1193182 pcd1193182 merged commit e483f07 into delphix:6.0/stage Mar 22, 2023
@pcd1193182 pcd1193182 deleted the uthread branch March 22, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants