-
Notifications
You must be signed in to change notification settings - Fork 21
Add userland stacks and threads commands #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbfdc2e to
b5127bb
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 6.0/stage #321 +/- ##
=============================================
- Coverage 87.81% 85.83% -1.99%
=============================================
Files 64 66 +2
Lines 2742 2859 +117
=============================================
+ Hits 2408 2454 +46
- Misses 334 405 +71
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahrens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a test case for this?
|
In terms of testing we can add a userland core dump to our test suite the same way we have kernel ones but the testing infrastructure will need to be adjusted a bit more. I can slowly start working on this. In the meantime I'm good with merging this. EDIT: Paul if you have a core dump that you used for development, you can try archiving it with |
Now that the stacks and threads commands have been properly separated into the kernel module, we can write a userland implementation of these commands. These implementations are heavily based on the originals, but using the generic drgn API that doesn't assume it can access the thread's object parameter. As a result, we have to lose the
moduleandstatefilters on the stacks.