DLPX-86794 sdb: zio broken after upstream ZFS commit #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `zio` command broke from the commit introduced by the following upstream PR: openzfs/zfs#14948 The problem is that the PR removed `io_parent_count` from `struct zio` and we are using this field to find the top-level ZIOs (e.g. ZIOs with no parents) in the system. This patch changes our SBD command to check whether the `io_parent_list` is populated instead. = Github Issue Tracker Automation Closes delphix#328
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #331 +/- ##
===========================================
+ Coverage 85.28% 85.31% +0.03%
===========================================
Files 67 67
Lines 3064 3071 +7
===========================================
+ Hits 2613 2620 +7
Misses 451 451
|
grwilson
reviewed
Jul 5, 2023
ahrens
approved these changes
Jul 5, 2023
mmaybee
approved these changes
Jul 6, 2023
grwilson
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
ziocommand broke from the commit introduced by the following upstream PR: openzfs/zfs#14948The problem is that the PR removed
io_parent_countfromstruct zioand we are using this field to find the top-level ZIOs (e.g. ZIOs with no parents) in the system.This patch changes our SBD command to check whether the
io_parent_listis populated instead.= Github Issue Tracker Automation
Closes #328