Fix regressions #346
Merged
Fix regressions #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint: mainly caused by drgn signature changes mypy: caused by drgn signature and behavior change pytest: commit 92fc92b regression
sdimitro
force-pushed
the
fix-failures-0
branch
from
3b92772 to
2a368f2
Compare
Contributor
Author
|
@jwk404 @prakashsurya @pcd1193182 @palash-gandhi @sebroy - for some reason I cannot add reviewers here. I've also created a "hard" fork of this repo (i.e. did not use the Github fork button) so I'll be probably silencing notifications from the Delphix repo soon. If it ends up being easier for your maintenance feel free to point linux-pkg to build directly from my new repo. |
sebroy
requested review from
jwk404,
palash-gandhi,
pcd1193182 and
prakashsurya
sebroy
approved these changes
Nov 11, 2024
jwk404
approved these changes
Nov 11, 2024
palash-gandhi
approved these changes
Nov 11, 2024
Contributor
Author
|
Can someone merge this for me? :) Need write access to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint: mainly caused by drgn signature changes
mypy: caused by drgn signature and behavior change
pytest: commit 92fc92b regression
I've been getting notifications of the test failures to my personal email everyday so I figured I'd fix failures :P