-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"[March 05, 2022] [BUG] retrieve_credentials() returns incorrect KeyPairCredentials object if credential_supplier has empty password" #427
Comments
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 5, 2022
…ntials object if credential_supplier has empty password
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 6, 2022
…ntials object if credential_supplier has empty password
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 10, 2022
…ntials object if credential_supplier has empty password
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 10, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 14, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 16, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 16, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 16, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 18, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Mar 24, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Apr 1, 2022
…sword during Lua to VSDK upgrade
Balamuruhan
added a commit
to Balamuruhan/virtualization-sdk
that referenced
this issue
Apr 1, 2022
…sword during Lua to VSDK upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
** Expected Behavior**
Even if
credentials_supplier
dict has empty password is should return PasswordCredentials() object but instead KeyPairCredentials() is returned.** Actual Behavior**
For EBS plugin implemented in vsdk, we use passwordCredentialsSupplier for System Password field which is retrieved from UI and used in our workflows. But this field is optional field, where user may not provide it in most of the cases. So when we upgrade the plugin from Lua to VSDK and empty password is passed in for System password field. After upgrade, when VSDK code retrieves it using retrieve_credentials() fails with AttributeError as retrieve_credentials() returns the KeyPairCredentials() instead of PasswordCredentials(). This is because there is a check
credentials_result.password != ""
which is incorrect, instead it should be"password" in credentials_supplier
Steps To Reproduce the Problem
Call the retrieve_credentials() with dict {'password': '', 'type': 'NamedPasswordCredential'},
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: