DOC-2125 Docs should mention that internet connection is needed for dvp build #426 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…symlinks folder and files.
…symlinks folder and files.
… into delphix-develop # Conflicts: # .bumpversion.cfg # common/src/main/python/dlpx/virtualization/common/VERSION # dvp/src/main/python/dlpx/virtualization/VERSION # libs/src/main/python/dlpx/virtualization/libs/VERSION # platform/src/main/python/dlpx/virtualization/platform/VERSION # tools/src/main/python/dlpx/virtualization/_internal/VERSION # tools/src/test/python/dlpx/virtualization/_internal/test_package_util.py
SumoSourabh
requested review from
vimleshmishra,
ravi-cm,
AleksandrLiber,
kurthdelphix,
mrburke and
jeffngo
AleksandrLiber
approved these changes
Apr 12, 2022
ravi-cm
approved these changes
Apr 13, 2022
nhlien93
approved these changes
Apr 18, 2022
jeffngo
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Document should mention that plugin developers will need internet connection to download packages from PyPI which are packaged with the zip file during dvp build.
Solution:
In
virtualization-sdk/Getting_Started/#requirementssection of thevirtualization-sdk/Getting_Started/page, we are adding one more requirement for an active internet connection with a tip on how to configure proxy server for packages download.Testing
Changes can be seen at - https://sumosourabh.github.io/virtualization-sdk/Getting_Started/#requirements
Attached a screenshot for quick reference.
