Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-9713 Update developer.delphix.com with support for additional mounts in AppData dSource #460

Merged
merged 12 commits into from
Mar 29, 2023
Merged

CP-9713 Update developer.delphix.com with support for additional mounts in AppData dSource #460

merged 12 commits into from
Mar 29, 2023

Conversation

SumoSourabh
Copy link
Contributor

@SumoSourabh SumoSourabh commented Mar 23, 2023 •
edited
Loading

Problem

The review contains document changes related to

  • 4.1.0 release.
  • multinode implementation for dSources.

Testing Done

The changes are available at https://sumosourabh.github.io/virtualization-sdk/.
All links worked. Checked via linkcheck.

Screenshots of the changes
Screenshot 2023-03-24 at 10 41 50 AM

Screenshot 2023-03-24 at 10 42 37 AM

Screenshot 2023-03-24 at 10 43 15 AM

SumoSourabh and others added 12 commits March 3, 2023 18:27
@SumoSourabh
CP-9575 Add support for additional mount in vsdk/dvp for dSources ope…
ef2f129 
…rations
@SumoSourabh
CP-9575 Add support for additional mount in vsdk/dvp for dSources ope…
365cc66 
…rations
@SumoSourabh
CP-9575 Add support for additional mount in vsdk/dvp for dSources ope…
62f60e6 
…rations
@SumoSourabh
Merge remote-tracking branch 'origin/forsync' into multinode
1ca4653 
# Conflicts:
#	tools/src/test/python/dlpx/virtualization/_internal/test_package_util.py
@SumoSourabh
CP-9575 Add support for additional mount in vsdk/dvp for dSources ope…
edc9845 
…rations
@SumoSourabh
CP-9575 Add support for additional mount in vsdk/dvp for dSources ope…
b83da8f 
…rations
@SumoSourabh
CP-9575 Add support for additional mount in vsdk/dvp for dSources ope…
a9d5d98 
…rations
@SumoSourabh
Merge branch 'delphix:develop' into multinode
8cbf9be
@SumoSourabh
CP-9713 Update developer.delphix.com with support for additional moun…
ddb027d 
…ts in AppData dSource
@SumoSourabh
CP-9713 Update developer.delphix.com with support for additional moun…
736132a 
…ts in AppData dSource
@SumoSourabh
CP-9713 Update developer.delphix.com with support for additional moun…
a584602 
…ts in AppData dSource
@SumoSourabh
CP-9713 Update developer.delphix.com with support for additional moun…
f986a83 
…ts in AppData dSource
@SumoSourabh SumoSourabh marked this pull request as ready for review March 24, 2023 05:27
@SumoSourabh SumoSourabh requested a review from a team as a code owner March 24, 2023 05:27
vimleshmishra
vimleshmishra approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@vimleshmishra vimleshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also highlight the reason for having both mount and mounts i.e. to support backward compatibility?

@SumoSourabh
Copy link
Contributor Author

Should we also highlight the reason for having both mount and mounts i.e. to support backward compatibility?

  • I think the design decisions can be left out from the documentation. We have already added when to use mount and mounts.

@SumoSourabh SumoSourabh merged commit fe704e1 into delphix:develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vimleshmishra vimleshmishra vimleshmishra approved these changes

@PiyushPGuptaG PiyushPGuptaG PiyushPGuptaG approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SumoSourabh @vimleshmishra @PiyushPGuptaG