Move hdfs-native-object-store dependency to cloud feature

delta-io · Jul 12, 2024 · 3b718f5 · 3b718f5
1 parent 54364dd
commit 3b718f5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/kernel/Cargo.toml b/kernel/Cargo.toml
@@ -62,6 +62,7 @@ cloud = [
   "object_store/azure",
   "object_store/gcp",
   "object_store/http",
+  "hdfs-native-object-store",
 ]
 default = ["sync-engine"]
 default-engine = [
@@ -77,7 +78,6 @@ default-engine = [
   "parquet/object_store",
   "reqwest",
   "tokio",
-  "hdfs-native-object-store"
 ]
 
 developer-visibility = []

diff --git a/kernel/src/engine/default/storage.rs b/kernel/src/engine/default/storage.rs
@@ -1,3 +1,4 @@
+#[cfg(feature = "cloud")]
 use hdfs_native_object_store::HdfsObjectStore;
 use object_store::parse_url_opts as object_store_parse_url_opts;
 use object_store::path::Path;
@@ -10,15 +11,18 @@ where
     K: AsRef<str>,
     V: Into<String>,
 {
-    let scheme = url.scheme();
-    if scheme == "hdfs" || scheme == "viewfs" {
-        let options_map = options
-            .into_iter()
-            .map(|(k, v)| (k.as_ref().to_string(), v.into()))
-            .collect();
-        let store = HdfsObjectStore::with_config(url.as_str(), options_map)?;
-        let path = Path::parse(url.path())?;
-        return Ok((Box::new(store), path));
+    #[cfg(feature = "cloud")]
+    {
+        let scheme = url.scheme();
+        if scheme == "hdfs" || scheme == "viewfs" {
+            let options_map = options
+                .into_iter()
+                .map(|(k, v)| (k.as_ref().to_string(), v.into()))
+                .collect();
+            let store = HdfsObjectStore::with_config(url.as_str(), options_map)?;
+            let path = Path::parse(url.path())?;
+            return Ok((Box::new(store), path));
+        }
     }
 
     object_store_parse_url_opts(url, options)