Skip to content

Commit

Permalink
address issues
Browse files Browse the repository at this point in the history
  • Loading branch information
OussamaSaoudi-db committed Dec 20, 2024
1 parent e8cc395 commit 67a8596
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 3 additions & 4 deletions kernel/tests/cdf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,9 @@ fn simple_cdf_version_ranges() -> DeltaResult<()> {
#[test]
fn update_operations() -> DeltaResult<()> {
let batches = read_cdf_for_table("cdf-table-update-ops", 0, 2, None)?;
// Note: `update_pre` and `update_post` are technically not part of the delta spec, but are
// part of the tests used in delta
// Note: `update_pre` and `update_post` are technically not part of the delta spec, and instead
// should be `update_preimage` and `update_postimage` respectively. However, the tests in
// delta-spark use the post and pre.
let mut expected = vec![
"+----+--------------+-----------------+",
"| id | _change_type | _commit_version |",
Expand Down Expand Up @@ -365,8 +366,6 @@ fn update_operations() -> DeltaResult<()> {
#[test]
fn false_data_change_is_ignored() -> DeltaResult<()> {
let batches = read_cdf_for_table("cdf-table-data-change", 0, 1, None)?;
// Note: `update_pre` and `update_post` are technically not part of the delta spec, but are
// part of the tests used in delta
let mut expected = vec![
"+----+--------------+-----------------+",
"| id | _change_type | _commit_version |",
Expand Down
2 changes: 0 additions & 2 deletions kernel/tests/common/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,9 @@ pub(crate) fn load_test_data(
test_name: &str,
) -> Result<tempfile::TempDir, Box<dyn std::error::Error>> {
let path = format!("{test_parent_dir}/{test_name}.tar.zst");
println!("Path: {path}");
let tar = zstd::Decoder::new(std::fs::File::open(path)?)?;
let mut archive = tar::Archive::new(tar);
let temp_dir = tempfile::tempdir()?;
println!("dir : {:?}", temp_dir.path());
archive.unpack(temp_dir.path())?;
Ok(temp_dir)
}
Expand Down

0 comments on commit 67a8596

Please sign in to comment.