-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add check for whether appendOnly table feature is supported or enabled #664
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 84.31% 84.27% -0.04%
==========================================
Files 77 77
Lines 19041 19051 +10
Branches 19041 19051 +10
==========================================
+ Hits 16054 16056 +2
- Misses 2191 2198 +7
- Partials 796 797 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f8eded9
to
78b689c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is something delta-rs needs right away, given that we don't have kernel code using it yet?
Hey @scovich sorry this message slipped! This check is going to be used on the write path soon ™️. Perhaps I'll mark it merge-hold until the write path infra is built. |
@scovich Ah I was missing one change. Added appendOnly to the set of writer features. The TableConfigurationCheck will be useful in the future when we add the ability to remove files. In that case, we'd have to assert that it's not enabled. Removing the merge-hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Zach Schuermann <zachary.zvs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes are proposed in this pull request?
This PR adds two functions to TableConfiguration:
It also enabled writes on tables with
AppendOnly
writer feature.How was this change tested?
I check that write is supported on Protocol with
WriterFeatures::AppendOnly
.