-
Notifications
You must be signed in to change notification settings - Fork 415
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Description The description of the main changes of your pull request # Related Issue(s) - closes #715 - closes #373 # Documentation <!--- Share links to useful documentation ---> --------- Co-authored-by: Robert Pack <42610831+roeap@users.noreply.github.com>
- Loading branch information
Showing
6 changed files
with
206 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
# Contributing to Python deltalake package | ||
|
||
## Workflow | ||
|
||
Most of the workflow is based on the `Makefile` and the `maturin` CLI tool. | ||
|
||
#### Setup your local environment with virtualenv | ||
|
||
```bash | ||
$ make setup-venv | ||
``` | ||
|
||
#### Activate it | ||
```bash | ||
$ source ./venv/bin/activate | ||
``` | ||
|
||
#### Ready to develop with maturin | ||
|
||
[maturin](https://github.com/PyO3/maturin) is used to build the python package. | ||
Install delta-rs in the current virtualenv | ||
|
||
```bash | ||
$ make develop | ||
``` | ||
|
||
Then, list all the available tasks | ||
|
||
```bash | ||
$ make help | ||
``` | ||
|
||
Format: | ||
|
||
```bash | ||
make format | ||
``` | ||
|
||
Check: | ||
|
||
```bash | ||
make check-python | ||
``` | ||
|
||
Unit test: | ||
|
||
```bash | ||
make unit-test | ||
``` | ||
|
||
## Release process | ||
|
||
1. Make a new PR to update the version in pyproject.toml. | ||
2. Once merged, push a tag of the format `python-vX.Y.Z`. This will trigger CI | ||
to create and publish release artifacts. | ||
3. In GitHub, create a new release based on the new tag. For release notes, | ||
use the generator at a starting point, but please revise them for brevity. | ||
Remove anything that is dev-facing only (chores), and bring all important | ||
changes to the top, leaving less important changes (such as dependabot | ||
updates) at the bottom. | ||
4. Once the artifacts are showing up in PyPI, announce the release in the delta-rs | ||
Slack channel. Be sure to give a shout-out to the new contributors. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.