Skip to content

Commit

Permalink
chore: improve docs + CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ion-elgreco authored and rtyler committed Aug 10, 2024
1 parent dcdb386 commit da824cd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/python_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
run: make check-rust

test-minimal:
name: Python Build (Python 3.8 PyArrow latest)
name: Python Build (Python 3.8 PyArrow 16.0.0)
runs-on: ubuntu-latest
env:
RUSTFLAGS: "-C debuginfo=line-tables-only"
Expand All @@ -49,7 +49,9 @@ jobs:
run: |
python -m venv venv
source venv/bin/activate
make develop
make setup
# Install minimum PyArrow version
pip install -e .[pandas,devel] pyarrow==16.0.0
env:
RUSTFLAGS: "-C debuginfo=line-tables-only"

Expand Down
5 changes: 3 additions & 2 deletions python/deltalake/schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ def _convert_pa_schema_to_delta(
Args
schema: Source schema
large_dtypes: If True, the pyarrow schema is casted to large_dtypes
large_view_passthrough: If True, String/Binary/Lists are passed through as is
schema_conversion_mode: large mode will cast all string/binary/list to the large version arrow types, normal mode
keeps the normal version of the types. Passthrough mode keeps string/binary/list flavored types in their original
version, whether that is view/large/normal.
"""
dtype_map = {
pa.uint8(): pa.int8(),
Expand Down
2 changes: 1 addition & 1 deletion python/deltalake/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ def merge(
target_alias: Optional[str] = None,
error_on_type_mismatch: bool = True,
writer_properties: Optional[WriterProperties] = None,
large_dtypes: bool = False,
large_dtypes: Optional[bool] = None,
custom_metadata: Optional[Dict[str, str]] = None,
post_commithook_properties: Optional[PostCommitHookProperties] = None,
) -> "TableMerger":
Expand Down

0 comments on commit da824cd

Please sign in to comment.