Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python package: Loosen version requirements for maturin #1004

Closed
gyscos opened this issue Dec 9, 2022 · 1 comment · Fixed by #1005
Closed

Python package: Loosen version requirements for maturin #1004

gyscos opened this issue Dec 9, 2022 · 1 comment · Fixed by #1005
Labels
enhancement New feature or request

Comments

@gyscos
Copy link
Contributor

gyscos commented Dec 9, 2022 •
edited
Loading

Description

The current python package requires an exact maturin version (currently 0.14.2):

delta-rs/python/pyproject.toml

Lines 1 to 2 in c1f5a7e

[build-system]
requires = ["maturin==0.14.2"]

Would you consider loosening it, for example to what is suggested in maturin's Readme?

[build-system]
requires = ["maturin>=0.14,<0.15"]

Use Case

This would let us build the python package with the latest maturin version (currently 0.14.5) rather than requiring an older version.
In my case it is to package the deltalake python package for archlinux.

The current workaround is to build the package in a virtualenv, but it's generally discouraged when a "direct" build is possible.

Thanks!
@gyscos gyscos added the enhancement New feature or request label Dec 9, 2022
@wjones127
Copy link
Collaborator

That restriction seems good to me, especially if maturin suggests it. 👍

Would you be wiling to submit a PR?

@gyscos gyscos mentioned this issue Dec 9, 2022
Merged
wjones127 pushed a commit that referenced this issue Dec 9, 2022
@gyscos
Loosen version requirement for maturin (#1005)
e0f953b 
# Description

This loosen the version requirement for maturin when building the python
package.

# Related Issue(s)

- closes #1004
<!---
For example:

- closes #106
--->

# Documentation

Using an exact version can be excessively restrictive, for example
preventing the use of the latest (but still compatible) version of
maturin. Especially when packaging for rolling-releases distributions
(like Archlinux), being able to build with the latest version would be
beneficial.
<!---
Share links to useful documentation
--->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loosen version requirement for maturin gyscos/delta-rs
2 participants
@gyscos @wjones127