Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo test does not run due to tls conflict #985

Closed
iajoiner opened this issue Dec 2, 2022 · 1 comment · Fixed by #1097
Closed

cargo test does not run due to tls conflict #985

iajoiner opened this issue Dec 2, 2022 · 1 comment · Fixed by #1097
Labels
bug Something isn't working

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Dec 2, 2022

Environment

Delta-rs version:
Commit 4efc67c
Binding:

Environment:

  • Cloud provider:
  • OS: Ubuntu 22.04
  • Other:

Bug

What happened:

error[E0252]: the name `tls` is defined multiple times
  --> /home/iajoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_core-0.48.0/src/lib.rs:25:5
   |
23 | use hyper_rustls as tls;
   |     ------------------- previous import of the module `tls` here
24 | #[cfg(feature = "native-tls")]
25 | use hyper_tls as tls;
   |     ^^^^^^^^^^^^^^^^ `tls` reimported here
   |
   = note: `tls` must be defined only once in the type namespace of this module
help: you can use `as` to change the binding name of the import
   |
25 | use hyper_tls as other_tls;
   |     ~~~~~~~~~~~~~~~~~~~~~~

error[E0599]: no function or associated item named `new` found for struct `hyper_rustls::HttpsConnector` in the current scope
   --> /home/iajoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_core-0.48.0/src/request.rs:224:41
    |
224 |         let connector = HttpsConnector::new();
    |                                         ^^^ function or associated item not found in `hyper_rustls::HttpsConnector<_>`

error[E0599]: no function or associated item named `new` found for struct `hyper_rustls::HttpsConnector` in the current scope
   --> /home/iajoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_core-0.48.0/src/request.rs:244:41
    |
244 |         let connector = HttpsConnector::new();
    |                                         ^^^ function or associated item not found in `hyper_rustls::HttpsConnector<_>`

What you expected to happen:

How to reproduce it:
Run cargo test at the top level

More details:
The essence of the problem is that we are using an unofficial AWS SDK crate, rusoto, that has been in maintenance mode since 2020 when there is in fact an official AWS SDK crate, https://github.com/awslabs/aws-sdk-rust now. Since rusoto has two mutually exclusive features without adding a compiler error to detect them being used in combination we have this bug.

@iajoiner iajoiner added the bug Something isn't working label Dec 2, 2022
@iajoiner
Copy link
Contributor Author

iajoiner commented Dec 2, 2022

OK this is a duplicate of #677. We need to fix this and add the top level CI so that any future regression will be detected.

wjones127 added a commit that referenced this issue Feb 11, 2023
# Description

Clean up our tls options so that we can run `cargo test` at the top
level again.

Also fixed clippy warnings that had accumulated.

# Related Issue(s)

- closes #985


# Documentation

<!---
Share links to useful documentation
--->
chitralverma pushed a commit to chitralverma/delta-rs that referenced this issue Mar 17, 2023
# Description

Clean up our tls options so that we can run `cargo test` at the top
level again.

Also fixed clippy warnings that had accumulated.

# Related Issue(s)

- closes delta-io#985


# Documentation

<!---
Share links to useful documentation
--->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant