Add provisional workaround to support CDC #1039 #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fazzani
requested review from
wjones127,
fvaleye,
rtyler,
roeap,
houqp,
xianwill and
mosyp
as code owners
wjones127
reviewed
Dec 25, 2022
wjones127
requested changes
Dec 25, 2022
There was a problem hiding this comment.
Thank you for adding the table and the test in Python.
The one main thing I'd like to see is a test in Rust. It would be appropriate here: https://github.com/delta-io/delta-rs/blob/main/rust/tests/read_delta_test.rs
Fazzani
force-pushed
the
main
branch
3 times, most recently
from
46eed55
to
e28e6c4
Compare
|
thank you @wjones127 for the review! |
|
@wjones127 |
I was waiting for all CI jobs to complete. Merged now. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is only a workaround to the bug #1039
now it is possible to load datatables with the CDC option activated
Related Issue(s)