add test for min_max_schema_for_fields #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
marijncv
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
wjones127
requested changes
Feb 6, 2023
There was a problem hiding this comment.
Since max_min_schema_for_fields is meant to be used multiple times on the same destination, perhaps it might be better to combine the tests into one where you call the function on each of the fields, and then assert the final dest result contains the right fields.
rust/src/delta_arrow.rs
Outdated
Comment on lines
748
to
757
| let f = ArrowField::new( | ||
| "struct", | ||
| ArrowDataType::Struct(vec![ArrowField::new("simple", ArrowDataType::Int32, true)]), | ||
| true, | ||
| ); | ||
| let expected = vec![ArrowField::new( | ||
| "struct", | ||
| ArrowDataType::Struct(vec![ArrowField::new("simple", ArrowDataType::Int32, true)]), | ||
| true, | ||
| )]; |
There was a problem hiding this comment.
We don't have to repeat this, and it's probably clearer they are meant to be the same field if we just clone f. Same applies for test above.
Suggested change
| let f = ArrowField::new( | |
| "struct", | |
| ArrowDataType::Struct(vec![ArrowField::new("simple", ArrowDataType::Int32, true)]), | |
| true, | |
| ); | |
| let expected = vec![ArrowField::new( | |
| "struct", | |
| ArrowDataType::Struct(vec![ArrowField::new("simple", ArrowDataType::Int32, true)]), | |
| true, | |
| )]; | |
| let f = ArrowField::new( | |
| "struct", | |
| ArrowDataType::Struct(vec![ArrowField::new("simple", ArrowDataType::Int32, true)]), | |
| true, | |
| ); | |
| let expected = vec![f.clone()]; |
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
|
Thanks for the pointers @wjones127! |
wjones127
approved these changes
Feb 6, 2023
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Marijn Valk <marijncv@hotmail.com> # Description Adds tests for `min_max_schema_for_fields` # Related Issue(s) <!--- For example: - closes delta-io#106 ---> # Documentation <!--- Share links to useful documentation ---> --------- Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marijn Valk marijncv@hotmail.com
Description
Adds tests for
min_max_schema_for_fieldsRelated Issue(s)
Documentation