Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AddAction timestamps to milliseconds. Fixes #1124 #1133

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

guyrt
Copy link
Contributor

@guyrt guyrt commented Feb 7, 2023

Description

Updates timestamp for AddActions to use milliseconds.

Related Issue(s)

Documentation

\

@github-actions github-actions bot added the binding/python Issues for the Python package label Feb 7, 2023
@guyrt
Copy link
Contributor Author

guyrt commented Feb 7, 2023

Planning on adding test prior to merge.

@guyrt
Copy link
Contributor Author

guyrt commented Feb 8, 2023

This is done and ready for review.

Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@wjones127 wjones127 merged commit 2bc471d into delta-io:main Feb 11, 2023
chitralverma pushed a commit to chitralverma/delta-rs that referenced this pull request Mar 17, 2023
…io#1133)

# Description
Updates timestamp for AddActions to use milliseconds.

# Related Issue(s)
- closes delta-io#1124 

# Documentation

\

---------

Co-authored-by: Tommy Guy <riguy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: modification time in add actions table is wrong
2 participants