Python write_deltalake fails if pyarrow table contains binary columns #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbushri
requested review from
wjones127,
fvaleye,
rtyler,
roeap and
houqp
as code owners
wjones127
requested changes
Feb 22, 2023
There was a problem hiding this comment.
Also, I tested the same data in PySpark, and they don't write stats. So we could also disable statistics collection for binary columns in the first place. I suppose not many people are using inequality filters on binary data. But this change should be sufficient for now.
|
Also, could you add a quick unit test based on your example in |
|
@rbushri are you wiling to add that unit test? |
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
…delta-io#1167) # Description Python write_deltalake fails if pyarrow table contains binary columns ending with 0x5c # Related Issue(s) Python write_deltalake fails if pyarrow table contains binary columns ending with 0x5c delta-io#1146 --------- Co-authored-by: rbushrian <rbushrian@akamai.com> Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python write_deltalake fails if pyarrow table contains binary columns ending with 0x5c
Related Issue(s)
Python write_deltalake fails if pyarrow table contains binary columns ending with 0x5c #1146