add boolean, date, timestamp & binary partition types #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
marijncv
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
marijncv
changed the title
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
requested changes
Mar 6, 2023
rust/src/writer/utils.rs
Outdated
Comment on lines
300
to
311
| ( | ||
| Arc::new(Int8Array::from(vec![Some(1), Some(2)])), | ||
| Some(String::from("1")), | ||
| ), | ||
| ( | ||
| Arc::new(Int16Array::from(vec![Some(1), Some(2)])), | ||
| Some(String::from("1")), | ||
| ), | ||
| ( | ||
| Arc::new(Int32Array::from(vec![Some(1), Some(2)])), | ||
| Some(String::from("1")), | ||
| ), |
There was a problem hiding this comment.
This can be applied to all the test cases: You shouldn't need the Some inside the array.
Suggested change
| ( | |
| Arc::new(Int8Array::from(vec![Some(1), Some(2)])), | |
| Some(String::from("1")), | |
| ), | |
| ( | |
| Arc::new(Int16Array::from(vec![Some(1), Some(2)])), | |
| Some(String::from("1")), | |
| ), | |
| ( | |
| Arc::new(Int32Array::from(vec![Some(1), Some(2)])), | |
| Some(String::from("1")), | |
| ), | |
| (Arc::new(Int8Array::from(vec![1])), Some("1")), | |
| (Arc::new(Int16Array::from(vec![1])), Some("1")), | |
| (Arc::new(Int32Array::from(vec![1])), Some("1")), |
rust/src/writer/utils.rs
Outdated
|
|
||
| #[test] | ||
| fn test_stringified_partition_value() { | ||
| let reference_pairs: Vec<(Arc<dyn Array>, Option<String>)> = vec![ |
There was a problem hiding this comment.
You can use &str instead to avoid needing String::from() in every test case.
Suggested change
| let reference_pairs: Vec<(Arc<dyn Array>, Option<String>)> = vec![ | |
| let reference_pairs: Vec<(Arc<dyn Array>, Option<&str>)> = vec![ |
rust/src/writer/utils.rs
Outdated
| ), | ||
| ]; | ||
| for (vals, result) in reference_pairs { | ||
| assert_eq!(stringified_partition_value(&vals).unwrap(), result) |
There was a problem hiding this comment.
You can use as_deref() to turn Option<String> into Option<&str>:
Suggested change
| assert_eq!(stringified_partition_value(&vals).unwrap(), result) | |
| assert_eq!( | |
| stringified_partition_value(&vals).unwrap().as_deref(), | |
| result | |
| ) |
rust/src/writer/utils.rs
Outdated
Comment on lines
332
to
338
| ( | ||
| Arc::new(StringArray::from(vec![ | ||
| Some(String::from("1")), | ||
| Some(String::from("2")), | ||
| ])), | ||
| Some(String::from("1")), | ||
| ), |
There was a problem hiding this comment.
The StringArray::from implementation can take a &str:
Suggested change
| ( | |
| Arc::new(StringArray::from(vec![ | |
| Some(String::from("1")), | |
| Some(String::from("2")), | |
| ])), | |
| Some(String::from("1")), | |
| ), | |
| (Arc::new(StringArray::from(vec!["1"])), Some("1")), |
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
# Description Adds boolean, date, timestamp & binary partition value types # Related Issue(s) closes delta-io#1170 --------- Signed-off-by: Marijn Valk <marijncv@hotmail.com> Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds boolean, date, timestamp & binary partition value types
Related Issue(s)
closes #1170