Enable passing Datafusion session state to WriteBuilder #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruuya
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
wjones127
approved these changes
Mar 1, 2023
Yeah that seems to be another issue. I created #1194 so we can look into it further. |
|
This is in fact sensible, one word of caution though. The conflict resolution requires us to gain some insights into the query execution that we may to collect as metrics. So while we will have to manage sessions and plans, there is a good chance we to think more about the APIs. |
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
# Description The session state can keep some context pertinent to the [input plan](https://github.com/delta-io/delta-rs/blob/main/rust/src/operations/write.rs#L153-L157), so passing it allows for building useful `TaskContext`s for executing the plan. This is especially the case when the input plan references another Delta table, which has previously registered it's object store (that needs to be accessible during the execution of the physical plan). # Related Issue(s) Closes delta-io#1186 Curiously, if in the test I use `delta-0.8.0-partitioned` the final `SELECT` query fails with: ``` External(Execution("Failed to map column projection for field year. Incompatible data types Dictionary(UInt16, Utf8) and Utf8")) ``` I'm not sure yet why this happens, but I think it has nothing to do with this change. # Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The session state can keep some context pertinent to the input plan, so passing it allows for building useful
TaskContexts for executing the plan.This is especially the case when the input plan references another Delta table, which has previously registered it's object store (that needs to be accessible during the execution of the physical plan).
Related Issue(s)
Closes #1186
Curiously, if in the test I use
delta-0.8.0-partitionedthe finalSELECTquery fails with:I'm not sure yet why this happens, but I think it has nothing to do with this change.
Documentation